Skip to content

chore: gradle example #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2020
Merged

chore: gradle example #147

merged 2 commits into from
Oct 23, 2020

Conversation

pankajagrawal16
Copy link
Contributor

@pankajagrawal16 pankajagrawal16 commented Oct 22, 2020

Issue #, if available:

closes #58

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pankajagrawal16 pankajagrawal16 changed the title gradle example chore: gradle example Oct 22, 2020
@pankajagrawal16 pankajagrawal16 requested a review from am29d October 22, 2020 09:11
@pankajagrawal16
Copy link
Contributor Author

So i will be externalizing the limitations of gradle setup as of today as part of issue template here #146.

Basically setup works with gradle5.x and not with 6.x coz of issue with the Aspect4j plugin.

@am29d
Copy link
Contributor

am29d commented Oct 22, 2020

Besides two minor points its LGTM:

  • the .jar file for the gradle wrapper is missing, was probably ignored by .gitignore.
  • should we merge example and gradle-example? I thought maybe having one folder with both build files would reduce the maintenance.

@pankajagrawal16
Copy link
Contributor Author

Besides two minor points its LGTM:

  • the .jar file for the gradle wrapper is missing, was probably ignored by .gitignore.
  • should we merge example and gradle-example? I thought maybe having one folder with both build files would reduce the maintenance.

Good catch. Pushed the wrapper jar now. 👍

Could you elaborate on the other point? I am not sure if I understand. 🙈

@am29d
Copy link
Contributor

am29d commented Oct 23, 2020

Besides two minor points its LGTM:

  • the .jar file for the gradle wrapper is missing, was probably ignored by .gitignore.
  • should we merge example and gradle-example? I thought maybe having one folder with both build files would reduce the maintenance.

Good catch. Pushed the wrapper jar now. 👍

Could you elaborate on the other point? I am not sure if I understand. 🙈

I am sorry I was looking into a wrong branch :(

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle plug-in for compile-time weave (CTW)
2 participants