Skip to content

docs(logging): correct log example keys #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

walmsles
Copy link
Contributor

@walmsles walmsles commented Sep 2, 2023

Issue #, if available:

Description of changes:

Correct logging JSON example shown near bottom of docs. Still shows lambda_request_id - see online here.

This PR updates this example (and others) to function_request_id, which aligns with the implementation here

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…m code: lambda_request_id --> function_request_id
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@scottgerring
Copy link
Contributor

Hi @walmsles nice catch! Thanks for the PR

@scottgerring scottgerring merged commit 2d7f024 into aws-powertools:main Sep 4, 2023
jeromevdl pushed a commit that referenced this pull request Oct 12, 2023
…m code: lambda_request_id --> function_request_id (#1411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants