Skip to content

chore: skip deployment in tests and examples #1388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

jeromevdl
Copy link
Contributor

Issue #, if available:

Description of changes:

Replaced the property maven.deploy.skip with the full plugin configuration to avoid deployment of tests and examples :

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8d03249) 78.93% compared to head (2761673) 78.93%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1388   +/-   ##
=========================================
  Coverage     78.93%   78.93%           
  Complexity      652      652           
=========================================
  Files            74       74           
  Lines          2506     2506           
  Branches        259      259           
=========================================
  Hits           1978     1978           
  Misses          446      446           
  Partials         82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scottgerring
Copy link
Contributor

scottgerring commented Aug 22, 2023

Perhaps this would work better the other way around - opt-in, rather than opt-out? Going forward we're likely to add more examples than modules I suspect, and that way the failure mode isn't accidentally publishing things. What do you think @jeromevdl ?

@jeromevdl
Copy link
Contributor Author

Perhaps this would work better the other way around - opt-in, rather than opt-out? Going forward we're likely to add more examples than modules I suspect, and that way the failure mode isn't accidentally publishing things. What do you think @jeromevdl ?

I don't know how/if it will work if we put the skip true on top and false below...

@scottgerring
Copy link
Contributor

Perhaps this would work better the other way around - opt-in, rather than opt-out? Going forward we're likely to add more examples than modules I suspect, and that way the failure mode isn't accidentally publishing things. What do you think @jeromevdl ?

I don't know how/if it will work if we put the skip true on top and false below...

Neither do I. The other question is - is there a way we can be sure this will work, this way around, without waiting til the next release?

@scottgerring
Copy link
Contributor

@jeromevdl let's merge this after the conflicts are resolved

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@scottgerring scottgerring merged commit e35de90 into main Aug 25, 2023
@scottgerring scottgerring deleted the chore/do_not_deploy branch August 25, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants