-
Notifications
You must be signed in to change notification settings - Fork 90
chore: skip deployment in tests and examples #1388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #1388 +/- ##
=========================================
Coverage 78.93% 78.93%
Complexity 652 652
=========================================
Files 74 74
Lines 2506 2506
Branches 259 259
=========================================
Hits 1978 1978
Misses 446 446
Partials 82 82 ☔ View full report in Codecov by Sentry. |
Perhaps this would work better the other way around - opt-in, rather than opt-out? Going forward we're likely to add more examples than modules I suspect, and that way the failure mode isn't accidentally publishing things. What do you think @jeromevdl ? |
I don't know how/if it will work if we put the skip true on top and false below... |
Neither do I. The other question is - is there a way we can be sure this will work, this way around, without waiting til the next release? |
@jeromevdl let's merge this after the conflicts are resolved |
Kudos, SonarCloud Quality Gate passed!
|
Issue #, if available:
Description of changes:
Replaced the property
maven.deploy.skip
with the full plugin configuration to avoid deployment of tests and examples :Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.