Skip to content

docs: Add additional workflow for rebuilding old versions of documentation #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kozub
Copy link
Contributor

@kozub kozub commented Aug 16, 2023

Issue #, if available:

#1239

This change is required only for rebuilding old documentation and publish it to S3. Should be reverted when job is done.

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kozub kozub self-assigned this Aug 16, 2023
@kozub kozub assigned kozub and unassigned kozub Aug 16, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kozub kozub requested a review from scottgerring August 16, 2023 09:48
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (bca90c9) 78.57% compared to head (64a3e37) 78.57%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1371   +/-   ##
=========================================
  Coverage     78.57%   78.57%           
  Complexity      651      651           
=========================================
  Files            74       74           
  Lines          2506     2506           
  Branches        259      259           
=========================================
  Hits           1969     1969           
  Misses          455      455           
  Partials         82       82           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scottgerring scottgerring changed the title Add additional workflow for rebuilding old versions of documentation docs: Add additional workflow for rebuilding old versions of documentation Aug 16, 2023
@@ -0,0 +1,100 @@
name: Rebuild old docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Rebuild old docs
#
# This workflow lets us rebuild and redeploy an old version of the documentation.
# Running it manually, specify a version and a git commit hash to deploy to that labeled version of the documentation.
# This can be used to either publish old versions of the documentation, or to replace the current version without cutting a release.
#
name: Rebuild old docs

type: string

permissions:
contents: write
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need contents or pages ?

pip install -r docs/requirements.txt
- name: Setup doc deploy
run: |
git config --global user.name Docs deploy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to set this if we aren't comitting and pushing?

Copy link
Contributor

@scottgerring scottgerring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Couple of comments inline.

Could you also add a brief section beneath "Releasing a new version" on re-deploying existing documentation - e.g. if we want to push a doc fix?

### Releasing a new version
!!! note "The release process is currently a long, multi-step process. The team is in the process of automating at it."
Firstly, make sure the commit history in the `main` branch **(1)** it's up to date, **(2)** commit messages are semantic,

@scottgerring scottgerring linked an issue Aug 30, 2023 that may be closed by this pull request
2 tasks
@scottgerring
Copy link
Contributor

Hey @kozub i'll close this for now, and we can re-open it when we have time to revisit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Version the documentation
3 participants