chore: cleanup spotbugs maven profiles

[jeromevdl]

Issue #, if available:

Description of changes:

profile 'without-spotbugs' is misleading and should be the default, and use 'with-spotbugs' when we want to run spotbugs check.
➡️ remove build-without-spotbugs profile
➡️ clean build-with-spotbugs that contains javadoc and source which should not be there
➡️ move the javadoc and source generation in the release profile (only needed at this stage to publish them on mvn central)

Checklist

• Meet tenets criteria
• Update tests
• Update docs
• PR title follows conventional commit semantics

Breaking change checklist

RFC issue #:

• Migration process documented
• Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[codecov-commenter]

Codecov Report

Patch and project coverage have no change.

Comparison is base (f30407c) 70.87% compared to head (1f3adcd) 70.87%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #1236   +/-   ##
=========================================
  Coverage     70.87%   70.87%           
  Complexity      541      541           
=========================================
  Files            72       72           
  Lines          2328     2328           
  Branches        254      254           
=========================================
  Hits           1650     1650           
  Misses          558      558           
  Partials        120      120           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[scottgerring]

lgtm