Skip to content

Docs: Improve SAM templates #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 task done
jeromevdl opened this issue Jul 11, 2023 · 6 comments
Closed
1 task done

Docs: Improve SAM templates #1278

jeromevdl opened this issue Jul 11, 2023 · 6 comments
Assignees
@AlexeySoshin
Labels
documentation Improvements or additions to documentation feature-request New feature or request maintenance priority:2 High - core feature or affects 60% of the users

Comments

@jeromevdl
Copy link
Contributor

What were you searching in the docs?

It's not in the doc per se, but the SAM templates (https://github.com/aws/aws-sam-cli-app-templates/pulls) are outdated:

Is this related to an existing documentation section?

No response

How can we improve?

  • bump powertools version (1.16.0)
  • update the v11+ configuration to use the dev.aspectj plugin instead of org.codehaus.mojo
  • test that it's working (logs, traces, metric) when creating a project and running it

Got a suggestion in mind?

  • optional : add a gradle version which we don't have today (maybe create another PR for that)

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@jeromevdl jeromevdl added documentation Improvements or additions to documentation feature-request New feature or request good-first-issue Good for newcomers maintenance labels Jul 11, 2023
@jeromevdl jeromevdl mentioned this issue Jul 11, 2023
Merged
6 tasks
@scottgerring
Copy link
Contributor

@AlexeySoshin are you interested in picking this one up?

@AlexeySoshin
Copy link
Contributor

Happy to pick this 😄

@jeromevdl jeromevdl added the priority:2 High - core feature or affects 60% of the users label Jul 17, 2023
@jeromevdl jeromevdl mentioned this issue Jul 17, 2023
Closed
@AlexeySoshin
Copy link
Contributor

@jeromevdl When you say "add a gradle version which we don't have today (maybe create another PR for that)" do you mean moving to Gradle 8? Or adding Gradle to Java 11 project? Or something else?

@AlexeySoshin AlexeySoshin mentioned this issue Jul 19, 2023
Merged
5 tasks
@AlexeySoshin
Copy link
Contributor

@scottgerring @jeromevdl

This has been merged now.

@scottgerring
Copy link
Contributor

Do we want to add a link to the examples README here to point this example out?

@AlexeySoshin AlexeySoshin mentioned this issue Jul 26, 2023
Merged
6 tasks
@jeromevdl
Copy link
Contributor Author

It's not something delivered in the next release. Closing.

@scottgerring scottgerring moved this from Working on it to Shipped in Powertools for AWS Lambda (Java) Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeySoshin AlexeySoshin

Labels
documentation Improvements or additions to documentation feature-request New feature or request maintenance priority:2 High - core feature or affects 60% of the users
Projects
Powertools for AWS Lambda (Java)
Status: Shipped
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeromevdl @scottgerring @AlexeySoshin