Skip to content

Rename MetricsUtils.withMetricLogger to MetricsUtils.withMetricsLogger #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
humanzz opened this issue Feb 20, 2023 · 1 comment
Closed

Rename MetricsUtils.withMetricLogger to MetricsUtils.withMetricsLogger #1059

humanzz opened this issue Feb 20, 2023 · 1 comment
Assignees
@humanzz
Labels
bug Something isn't working triage

Comments

@humanzz
Copy link
Contributor

humanzz commented Feb 20, 2023

#1000 introduced the wrongly named MetricsUtils.withMetricLogger. To be consistent, it should have been called MetricsUtils.withMetricsLogger.

Deprecate MetricsUtils.withMetricLogger and introduce MetricsUtils.withMetricsLogger.
@humanzz humanzz added bug Something isn't working triage labels Feb 20, 2023
humanzz added a commit to humanzz/aws-lambda-powertools-java that referenced this issue Feb 20, 2023
@humanzz
chore(metrics): deprecated MetricsUtils.withMetricLogger in favor of …
8a30161 
…deprecated MetricsUtils.withMetricsLogger

closes aws-powertools#1059
humanzz added a commit to humanzz/aws-lambda-powertools-java that referenced this issue Feb 20, 2023
@humanzz
chore(metrics): deprecated MetricsUtils.withMetricLogger in favor of …
89f379a 
…MetricsUtils.withMetricsLogger

closes aws-powertools#1059
@humanzz humanzz mentioned this issue Feb 20, 2023
Merged
6 tasks
@kozub kozub assigned kozub and humanzz and unassigned kozub Feb 21, 2023
@jeromevdl
Copy link
Contributor

fixed with #1060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humanzz humanzz

Labels
bug Something isn't working triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@humanzz @jeromevdl @kozub