Skip to content

Commit 43ea342

Browse files
author
Pankaj Agrawal
committed
chore: spotsbug check fix for remote forks pr
1 parent ab0406d commit 43ea342

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

.github/workflows/spotbugs.yml

+9-6
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,14 @@ jobs:
2424
with:
2525
distribution: 'zulu'
2626
java-version: 8
27-
- name: Build with Maven for spotbugs check to gather reports
28-
run: mvn -Pbuild-with-spotbugs -B install --file pom.xml -DskipTests -Dmaven.javadoc.skip=true -Dspotbugs.failOnError=false
29-
- uses: jwgmeligmeyling/spotbugs-github-action@master
30-
with:
31-
path: '**/spotbugsXml.xml'
32-
# Can be simplified post this issue is fixed https://github.com/jwgmeligmeyling/spotbugs-github-action/issues/9
27+
# https://github.com/jwgmeligmeyling/spotbugs-github-action/issues/6
28+
# https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/
29+
# Avoid complexity of git action with publishing report. Just build with spotbugs profile.
30+
# - name: Build with Maven for spotbugs check to gather reports
31+
# run: mvn -Pbuild-with-spotbugs -B install --file pom.xml -DskipTests -Dmaven.javadoc.skip=true -Dspotbugs.failOnError=false
32+
# - uses: jwgmeligmeyling/spotbugs-github-action@master
33+
# with:
34+
# path: '**/spotbugsXml.xml'
35+
# # Can be simplified post this issue is fixed https://github.com/jwgmeligmeyling/spotbugs-github-action/issues/9
3336
- name: Build with Maven for spotbugs check to mark build as fail if voilations found
3437
run: mvn -Pbuild-with-spotbugs -B install --file pom.xml -DskipTests -Dmaven.javadoc.skip=true -Dspotbugs.failOnError=true

powertools-sqs/src/main/java/software/amazon/lambda/powertools/sqs/SQSBatchProcessingException.java

-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ public class SQSBatchProcessingException extends RuntimeException {
3333
private final List<SQSMessage> failures;
3434
private final List<Object> returnValues;
3535

36-
3736
public <T> SQSBatchProcessingException(final List<Exception> exceptions,
3837
final List<SQSMessage> failures,
3938
final List<T> successReturns) {

0 commit comments

Comments
 (0)