Skip to content

chore: Update tracing.md - Auto-disable when not running in AWS Lambda environment #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jan 18, 2024

Auto-disable when not running in AWS Lambda environment

Please provide the issue number

Issue number: #543

Summary

Auto-disable when not running in AWS Lambda environment

Changes

Please provide a summary of what's being changed

Add Auto-disable when not running in AWS Lambda environment to docs

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Auto-disable when not running in AWS Lambda environment

Signed-off-by: Henrique Graca <[email protected]>
@auto-assign auto-assign bot requested review from amirkaws and sliedig January 18, 2024 15:41
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label Jan 18, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 18, 2024
@github-actions github-actions bot added the internal Maintenance changes label Jan 18, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7308cc6) 72.23% compared to head (959db8e) 72.11%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #544      +/-   ##
===========================================
- Coverage    72.23%   72.11%   -0.13%     
===========================================
  Files          101      101              
  Lines         4106     4106              
  Branches       418      418              
===========================================
- Hits          2966     2961       -5     
  Misses        1026     1026              
- Partials       114      119       +5     
Flag Coverage Δ
unittests 72.11% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjgraca hjgraca merged commit c513fff into develop Jan 23, 2024
@hjgraca hjgraca deleted the hjgraca-docs-auto-disable-tracing branch January 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants