Skip to content

Commit be0747c

Browse files
authored
Merge pull request #23 from toricls/respect-overridden-task-role
Respect overridden task role for permission check
2 parents f03bd34 + 2ccf1b7 commit be0747c

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

check-ecs-exec.sh

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,12 @@ for enabled in $initEnabledList; do
400400
done
401401

402402
# 8. Check the task role permissions
403-
taskRoleArn=$(echo "${taskDefJson}" | jq -r ".taskDefinition.taskRoleArn")
403+
overriddenTaskRole=true
404+
taskRoleArn=$(echo "${describedTaskJson}" | jq -r ".tasks[0].overrides.taskRoleArn")
405+
if [[ "x${taskRoleArn}" = "xnull" ]]; then
406+
overriddenTaskRole=false
407+
taskRoleArn=$(echo "${taskDefJson}" | jq -r ".taskDefinition.taskRoleArn")
408+
fi
404409

405410
hasRole=true
406411
isEC2Role=false
@@ -436,7 +441,11 @@ else
436441
else
437442
printf "${COLOR_DEFAULT} Task Role Permissions | "
438443
fi
439-
printf "${taskRoleArn}\n"
444+
printf "${taskRoleArn}"
445+
if [[ "x${overriddenTaskRole}" = "xtrue" ]]; then
446+
printf " (Overridden)"
447+
fi
448+
printf "\n"
440449
## Required Permissions
441450
### SSM
442451
ssm="ssmmessages:"

0 commit comments

Comments
 (0)