Skip to content

non-strict deserializer for request data #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ammokhov
Copy link
Contributor

@ammokhov ammokhov commented Nov 24, 2020

Issue #, if available:

Description of changes:

prevents deserialization exceptions on any undesired properties

% pre-commit run --all-files
isort....................................................................Passed
black....................................................................Passed
Check for case conflicts.................................................Passed
Fix End of Files.........................................................Passed
Mixed line ending........................................................Passed
Trim Trailing Whitespace.................................................Passed
Flake8...................................................................Passed
Pretty format JSON...................................(no files to check)Skipped
Check for merge conflicts................................................Passed
Check Yaml...............................................................Passed
Check blanket noqa.......................................................Passed
check for not-real mock methods..........................................Passed
use logger.warning(......................................................Passed
bandit...................................................................Passed
mypy.....................................................................Passed
pylint-local.............................................................Passed
pytest-local.............................................................Passed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

@srujithpoondla03 srujithpoondla03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably after this change we need to audit the whole plugin to be in sync with the other plugin's deserialization behavior.

Copy link
Contributor

@jaymccon jaymccon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ammokhov ammokhov merged commit fa5a3fe into aws-cloudformation:master Nov 25, 2020
@ammokhov ammokhov deleted the request-data-deserializer branch November 25, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working WIP Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creation of custom resource fails with: __init__() got an unexpected keyword argument 'typeConfiguration' (TypeError)
3 participants