Convert resolver errors to warnings (#3493)

Author: kddejong

src/cfnlint/rules/functions/FindInMap.py

@@ -21,7 +21,9 @@ class FindInMap(BaseFn):
     tags = ["functions", "findinmap"]
 
     def __init__(self) -> None:
-        super().__init__("Fn::FindInMap", ("array",) + singular_types)
+        super().__init__(
+            "Fn::FindInMap", ("array",) + singular_types, resolved_rule="W1034"
+        )
 
     def schema(self, validator: Validator, instance: Any) -> dict[str, Any]:
         scalar_schema = {

src/cfnlint/rules/functions/FindInMapResolved.py

@@ -0,0 +1,16 @@
+"""
+Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+SPDX-License-Identifier: MIT-0
+"""
+
+from cfnlint.rules import CloudFormationLintRule
+
+
+class FindInMapResolved(CloudFormationLintRule):
+    id = "W1034"
+    shortdesc = "Validate the values that come from a Fn::FindInMap function"
+    description = (
+        "Resolve the Fn::FindInMap and then validate the values against the schema"
+    )
+    source_url = "https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-findinmap.html"
+    tags = ["functions", "findinmap"]

src/cfnlint/rules/functions/GetAz.py

@@ -22,7 +22,7 @@ class GetAz(BaseFn):
     tags = ["functions", "getaz"]
 
     def __init__(self) -> None:
-        super().__init__("Fn::GetAZs", ("array",), ("Ref",))
+        super().__init__("Fn::GetAZs", ("array",), ("Ref",), resolved_rule="W1036")
         self.fn_getazs = self.validate
 
     def schema(self, validator: Validator, instance: Any) -> dict[str, Any]:

src/cfnlint/rules/functions/GetAzResolved.py

@@ -0,0 +1,16 @@
+"""
+Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+SPDX-License-Identifier: MIT-0
+"""
+
+from cfnlint.rules import CloudFormationLintRule
+
+
+class FindInMapResolved(CloudFormationLintRule):
+    id = "W1036"
+    shortdesc = "Validate the values that come from a Fn::GetAZs function"
+    description = (
+        "Resolve the Fn::GetAZs and then validate the values against the schema"
+    )
+    source_url = "https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-getavailabilityzones.html"
+    tags = ["functions", "getazs"]

src/cfnlint/rules/functions/Join.py

@@ -22,10 +22,12 @@ class Join(BaseFn):
     tags = ["functions", "join"]
 
     def __init__(self) -> None:
-        super().__init__("Fn::Join", ("string",))
-        self.child_rules = {
-            "I1022": None,
-        }
+        super().__init__("Fn::Join", ("string",), resolved_rule="W1032")
+        self.child_rules.update(
+            {
+                "I1022": None,
+            }
+        )
 
     def schema(self, validator, instance) -> dict[str, Any]:
         return {

src/cfnlint/rules/functions/JoinResolved.py

@@ -0,0 +1,14 @@
+"""
+Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+SPDX-License-Identifier: MIT-0
+"""
+
+from cfnlint.rules import CloudFormationLintRule
+
+
+class JoinResolved(CloudFormationLintRule):
+    id = "W1032"
+    shortdesc = "Validate the values that come from a Fn::Join function"
+    description = "Resolve the Fn::Join and then validate the values against the schema"
+    source_url = "https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-join.html"
+    tags = ["functions", "join"]

src/cfnlint/rules/functions/Ref.py

@@ -22,11 +22,11 @@ class Ref(BaseFn):
     tags = ["functions", "ref"]
 
     def __init__(self) -> None:
-        super().__init__("Ref", all_types)
+        super().__init__("Ref", all_types, resolved_rule="W1030")
         self._all_refs = [
             "W2010",
         ]
-        self.child_rules = dict.fromkeys(self._all_refs)
+        self.child_rules.update(dict.fromkeys(self._all_refs))
 
     def schema(self, validator, instance) -> dict[str, Any]:
         return {
@@ -94,5 +94,7 @@ def ref(self, validator, subschema, instance, schema):
         for rule in self.child_rules.values():
             if not rule or rule.id in self._all_refs:
                 continue
+            if not hasattr(rule, "keywords"):
+                continue
             if keyword in rule.keywords:
                 yield from rule.validate(validator, keyword, instance, schema)

src/cfnlint/rules/functions/RefResolved.py

@@ -0,0 +1,14 @@
+"""
+Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+SPDX-License-Identifier: MIT-0
+"""
+
+from cfnlint.rules import CloudFormationLintRule
+
+
+class RefResolved(CloudFormationLintRule):
+    id = "W1030"
+    shortdesc = "Validate the values that come from a Ref function"
+    description = "Resolve the Ref and then validate the values against the schema"
+    source_url = "https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-ref.html"
+    tags = ["functions", "ref"]

src/cfnlint/rules/functions/Select.py

@@ -21,7 +21,7 @@ class Select(BaseFn):
     tags = ["functions", "select"]
 
     def __init__(self) -> None:
-        super().__init__("Fn::Select", all_types)
+        super().__init__("Fn::Select", all_types, resolved_rule="W1035")
         self.fn_select = self.validate
 
     def schema(self, validator: Validator, instance: Any) -> dict[str, Any]:

src/cfnlint/rules/functions/SelectResolved.py

@@ -0,0 +1,16 @@
+"""
+Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+SPDX-License-Identifier: MIT-0
+"""
+
+from cfnlint.rules import CloudFormationLintRule
+
+
+class SelectResolved(CloudFormationLintRule):
+    id = "W1035"
+    shortdesc = "Validate the values that come from a Fn::Select function"
+    description = (
+        "Resolve the Fn::Select and then validate the values against the schema"
+    )
+    source_url = "https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-select.html"
+    tags = ["functions", "select"]