Fix run-status / normalizeError

Author: jakwuh

lib/run-status.js

@@ -18,10 +18,15 @@ function sum(arr, key) {
 }
 
 function normalizeError(err) {
-	if (!isObj(err)) {
+	if (isObj(err) && 'message' in err && typeof err.message === 'string') {
+		['name', 'stack'].forEach(field => {
+			if (field in err && typeof err[field] !== 'string') {
+				delete err[field];
+			}
+		});
+	} else {
 		err = {
-			message: err,
-			stack: err
+			message: String(err)
 		};
 	}
 

test/run-status.js

@@ -87,3 +87,53 @@ test('calculate remaining test count', t => {
 	t.end();
 });
 
+test('handle non-object rejections', t => {
+	const runStatus = new RunStatus();
+
+	runStatus.on('error', err => {
+		t.deepEqual(err, {
+			file: 'foo.js',
+			message: '42',
+			type: 'rejection'
+		});
+		t.end();
+	});
+
+	runStatus.handleRejections({file: 'foo.js', rejections: [42]});
+});
+
+test('handle non-object exceptions', t => {
+	const runStatus = new RunStatus();
+
+	runStatus.on('error', err => {
+		t.deepEqual(err, {
+			file: 'bar.js',
+			message: '/ab/g',
+			type: 'exception'
+		});
+		t.end();
+	});
+
+	runStatus.handleExceptions({file: 'bar.js', exception: /ab/g});
+});
+
+test('remove non-string error properties from error-like objects', t => {
+	const runStatus = new RunStatus();
+
+	runStatus.on('error', err => {
+		t.deepEqual(err, {
+			file: 'bar.js',
+			message: 'err msg',
+			type: 'rejection'
+		});
+		t.end();
+	});
+
+	const err = {
+		message: 'err msg',
+		stack: {},
+		name: ['baz']
+	};
+
+	runStatus.handleRejections({file: 'bar.js', rejections: [err]});
+});