-
Notifications
You must be signed in to change notification settings - Fork 5
Closed
Copy link
Labels
enhancementNew feature or requestNew feature or requestfeatureRequestideas or functions that would be usefulideas or functions that would be useful
Description
Right now handling of "unaffected cells" in a com4FlowPy model domain is not done consistently for all different output layers.
"unaffected cells"
depending on the calculated output raster, these "unaffected cells" are encoded differently in the model outputs.
- e.g. in the
backcalculationandforestInteractionoutputs non-affected cells are encoded with-9999, the result array is initiated withnp.ones_like() * -9999 - all other output rasters are currently initialized with
np.zeros_like()leading to encoding of unaffected-cells with '0' - this is in principal ok for all outputs where affected-cells (release and/or modeled runout) will contain values '>0' anyways (e.g.
cellCounts,flux, ...), but leads to ambiguous results for outputs also having0values in affected cells (e.g.zDelta,travelLength, ´fpTravelAngle`, ...)
Note: Maybe a simple solution to this problem would be to keep track of "affected cells" in a binary np.array() and handle the encoding of "unaffected cells" just before writing the output files instead of having multiple checks at model runtime (as required with initializing with np.ones_like() * -9999)
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestfeatureRequestideas or functions that would be usefulideas or functions that would be useful