-
Notifications
You must be signed in to change notification settings - Fork 3
docs: add libevm/README.md documentation #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
….md to libevm/README.md
with: | ||
globs: | | ||
libevm/**.md | ||
config: .github/workflows/configs/.markdownlint.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config: .github/workflows/configs/.markdownlint.json | |
config: .github/workflows/configs/markdownlint.json |
This is already in the hidden .github
directory so no point hiding the file too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the only point is to have it match the file icon and json schema, given the default markdown lint config file name is .markdownlint.json
. But I can remove the leading dot if you feel it's important
@@ -0,0 +1,3 @@ | |||
{ | |||
"MD013": false | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a new line at the end of the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's my JSON auto-formatter, it does remove trailing new lines for json files 😄
libevm/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(fyi) I haven't reviewed this file yet.
Why this should be merged
Documentation for the libevm repository was lacking and requested, so here it is.
This consists of moving all libevm-related documentation in
libevm/README.md
.Now the root
README.md
only has a reference tolibevm/README.md
to reduce diffs even more with geth code.This new readme, on top of taking existing documentation from the root readme, explains the following:
How this works
How this was tested