Skip to content

docs: add libevm/README.md documentation #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

docs: add libevm/README.md documentation #175

wants to merge 13 commits into from

Conversation

qdm12
Copy link

@qdm12 qdm12 commented Apr 3, 2025

Why this should be merged

Documentation for the libevm repository was lacking and requested, so here it is.
This consists of moving all libevm-related documentation in libevm/README.md.
Now the root README.md only has a reference to libevm/README.md to reduce diffs even more with geth code.

This new readme, on top of taking existing documentation from the root readme, explains the following:

  • Rules followed by libevm
  • Advantages of libevm
  • Root reason to develop libevm
  • Geth upgrade process
  • Implementation of libevm, describing each hook and their purpose - I think this is beneficial for newcomers to understand a bit the hook system.

How this works

How this was tested

with:
globs: |
libevm/**.md
config: .github/workflows/configs/.markdownlint.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
config: .github/workflows/configs/.markdownlint.json
config: .github/workflows/configs/markdownlint.json

This is already in the hidden .github directory so no point hiding the file too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the only point is to have it match the file icon and json schema, given the default markdown lint config file name is .markdownlint.json. But I can remove the leading dot if you feel it's important

@@ -0,0 +1,3 @@
{
"MD013": false
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a new line at the end of the file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's my JSON auto-formatter, it does remove trailing new lines for json files 😄

libevm/README.md Outdated
Copy link
Collaborator

@ARR4N ARR4N Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(fyi) I haven't reviewed this file yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants