-
Notifications
You must be signed in to change notification settings - Fork 3
chore(core/rawdb): ExampleInspectDatabase
test
#119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(core/rawdb): ExampleInspectDatabase
test
#119
Conversation
52e6180
to
02fbb8b
Compare
02fbb8b
to
2fabe02
Compare
2fabe02
to
eff72a3
Compare
I was initially planning to (ill-fated plan):
The 🆕 plan:
I'll comment on previous comments just for the sake of discussion and a pre-review on an upstream PR, but these conversations are unimportant so feel free to ignore too 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much easier to understand, making it "obviously" correct, which is what tests should strive to be IMO. Thanks for taking the extra time.
Why this should be merged
Add an example test for
InspectDatabase
with options.How this works
See example code