chore(core/types): add Test_Body_hasOptionalFields to enforce hasLaterOptionalField is up to date
#113
Conversation
|
Any fields added in the future will have to be optional. The change-detector will pick up on these too. |
yes but it would not pick up if we forget to update the |
core/types/block.libevm.go
Outdated
| @@ -146,6 +146,10 @@ func (b *Body) EncodeRLP(dst io.Writer) error { | |||
| }) | |||
| } | |||
|
|
|||
| func (b *Body) hasOptionalFields() bool { | |||
There was a problem hiding this comment.
| func (b *Body) hasOptionalFields() bool { | |
| func (b *Body) hasOptionalFieldsSet() bool { |
There was a problem hiding this comment.
Renamed to hasAnyOptionalFieldSet since it should be true if any (not all) optional field is set.
| field := v.Field(i) | ||
| before := field.Interface() | ||
| switch field.Kind() { | ||
| case reflect.Slice: |
There was a problem hiding this comment.
This needs support for reflect.Pointer as the optional fields can be struct pointers.
There was a problem hiding this comment.
We can just add them later on a add-when-needed basis. If it's not defined in the switch, the test would fail
qdm12
force-pushed
the
qdm12/body-rlp-override-optional-test
branch
from
03e6373 to
a0cec28
Compare
…erOptionalField` is up to date
Co-authored-by: Arran Schlosberg <[email protected]> Signed-off-by: Quentin McGaw <[email protected]>
qdm12
force-pushed
the
qdm12/body-rlp-override-optional-test
branch
from
a0cec28 to
24b3aec
Compare
|
This will likely be made obsolete by #120 |
qdm12
added
the
Status: 🔴 DO NOT MERGE
|
Unnecessary following merge of #120 |
Why this should be merged
To enforce updating the
hasLaterOptionalFieldfield if more optional fields are added toBodyHow this works
Use some reflect magic in a unit test
How this was tested