Skip to content

Commit 0334683

Browse files
fix: module advice must be 'actionable' to be 'not empty'.
1 parent 20377ed commit 0334683

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/main/kotlin/com/autonomousapps/internal/advice/ProjectHealthConsoleReportBuilder.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ internal class ProjectHealthConsoleReportBuilder(
199199
}
200200

201201
private fun Set<ModuleAdvice>.hasPrintableAdvice(): Boolean {
202-
return isNotEmpty() && filterIsInstance<AndroidScore>().any { it.couldBeJvm() }
202+
return ModuleAdvice.isNotEmpty(this)
203203
}
204204

205205
private fun AndroidScore.text() = buildString {

src/main/kotlin/com/autonomousapps/model/ProjectAdvice.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ data class ProjectAdvice(
2020
/** Returns true if this has no advice, nor any warnings. */
2121
fun isEmpty(): Boolean = dependencyAdvice.isEmpty()
2222
&& pluginAdvice.isEmpty()
23-
&& moduleAdvice.isEmpty()
23+
&& ModuleAdvice.isEmpty(moduleAdvice)
2424
&& warning.isEmpty()
2525

2626
/**

0 commit comments

Comments
 (0)