Port over to AutoML common (#1318)

* Add submodule

* Port to abstract_ensemble, backend from automl_common

* Updated workflow files

* Update imports

* Trigger actions

* Another import fix

* update import

* m

* Backend fixes

* Backend parameter update

* fixture fix for backend

* Fix tests

* readd old abstract ensemble for now

* flake8'd

* Added install from source to readme

* Moved installation w.r.t submodules to the docs

* Temporarily remove submodule

* Readded submodule

* Updated to use automl_common under autosklearn

* Updated MANIFEST

* Removed uneeded statements from MANIFEST

* Fixed import

* Fixed comment line in MANIFEST.in

* Added automl_common/setup.py to MANIFEST

* Added prefix to script

* Re-added removed title #

* Added note for submodule for CONTRIBUTING

* Made the submodule step a bit more clear for contributing.md

* CONTRIBUTING fixes

Author: eddiebergman

.github/workflows/dist.yml

@@ -5,25 +5,34 @@ on: [push, pull_request]
 jobs:
   dist:
     runs-on: ubuntu-latest
+
     steps:
-    - uses: actions/checkout@v2
+    - name: Check out the repo
+      uses: actions/checkout@v2
+      with:
+        submodules: recursive
+
     - name: Setup Python
       uses: actions/setup-python@v2
       with:
         python-version: 3.8
+
     - name: Build dist
       run: |
         python setup.py sdist
+
     - name: Twine check
       run: |
         pip install twine
         last_dist=$(ls -t dist/auto-sklearn-*.tar.gz | head -n 1)
         twine_output=`twine check "$last_dist"`
         if [[ "$twine_output" != "Checking $last_dist: PASSED" ]]; then echo $twine_output && exit 1;fi
+
     - name: Install dist
       run: |
         last_dist=$(ls -t dist/auto-sklearn-*.tar.gz | head -n 1)
         pip install $last_dist
+
     - name: PEP 561 Compliance
       run: |
         pip install mypy

.github/workflows/docker-publish.yml

@@ -12,13 +12,18 @@ jobs:
   push_to_registry:
     name: Push Docker image to GitHub Packages
     runs-on: ubuntu-latest
+
     steps:
       - name: Check out the repo
         uses: actions/checkout@v2
+        with:
+          submodules: recursive
+
       - name: Extract branch name
         shell: bash
         run: echo "##[set-output name=branch;]$(echo ${GITHUB_REF#refs/heads/})"
         id: extract_branch
+
       - name: Push to GitHub Packages
         uses: docker/build-push-action@v1
         with:
@@ -28,26 +33,32 @@ jobs:
           repository: automl/auto-sklearn/auto-sklearn
           tag_with_ref: true
           tags: ${{ steps.extract_branch.outputs.branch }}
+
       - name: Push to Docker Hub
         uses: docker/build-push-action@v1
         with:
           username: ${{ secrets.DOCKER_USERNAME }}
           password: ${{ secrets.DOCKER_PASSWORD }}
           repository: mfeurer/auto-sklearn
           tags: ${{ steps.extract_branch.outputs.branch }}
+
       - name: Docker Login
         run: docker login docker.pkg.github.com -u $GITHUB_ACTOR -p $GITHUB_TOKEN
         env:
             GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
+
       - name: Pull Docker image
         run: docker pull docker.pkg.github.com/$GITHUB_REPOSITORY/auto-sklearn:$BRANCH
         env:
             BRANCH: ${{ steps.extract_branch.outputs.branch }}
+
       - name: Run image
         run: docker run -i -d --name unittester -v $GITHUB_WORKSPACE:/workspace -w /workspace docker.pkg.github.com/$GITHUB_REPOSITORY/auto-sklearn:$BRANCH
         env:
             BRANCH: ${{ steps.extract_branch.outputs.branch }}
+
       - name: Auto-Sklearn loaded
         run: docker exec  -i unittester python3 -c 'import autosklearn; print(f"Auto-sklearn imported from {autosklearn.__file__}")'
+
       - name: Run unit testing
         run: docker exec  -i unittester python3 -m pytest -v test

.github/workflows/docs.yml

@@ -6,33 +6,42 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
+      with:
+        submodules: recursive
+
     - name: Setup Python
       uses: actions/setup-python@v2
       with:
         python-version: 3.8
+
     - name: Install dependencies
       run: |
-        pip install -e .[docs,examples,examples_unix]
+        pip install -e .[docs,examples]
+
     - name: Make docs
       run: |
         cd doc
         make html
+
     - name: Check links
       run: |
         cd doc
         make linkcheck
+
     - name: Pull latest gh-pages
       if: (contains(github.ref, 'develop') || contains(github.ref, 'master')) && github.event_name == 'push'
       run: |
         cd ..
         git clone https://github.com/automl/auto-sklearn.git --branch gh-pages --single-branch gh-pages
+
     - name: Copy new doc into gh-pages
       if: (contains(github.ref, 'develop') || contains(github.ref, 'master')) && github.event_name == 'push'
       run: |
         branch_name=${GITHUB_REF##*/}
         cd ../gh-pages
         rm -rf $branch_name
         cp -r ../auto-sklearn/doc/build/html $branch_name
+
     - name: Push to gh-pages
       if: (contains(github.ref, 'develop') || contains(github.ref, 'master')) && github.event_name == 'push'
       run: |

.github/workflows/pre-commit.yaml

@@ -7,14 +7,19 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
+      with:
+        submodules: recursive
+
     - name: Setup Python 3.7
       uses: actions/setup-python@v2
       with:
         python-version: 3.7
+
     - name: Install pre-commit
       run: |
         pip install pre-commit
         pre-commit install
+
     - name: Run pre-commit
       run: |
         pre-commit run --all-files

.github/workflows/pytest.yml

@@ -28,6 +28,9 @@ jobs:
     steps:
 
     - uses: actions/checkout@v2
+      with:
+        submodules: recursive
+
     - name: Setup Python ${{ matrix.python-version }}
       uses: actions/setup-python@v2
       # A note on checkout: When checking out the repository that

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "autosklearn/automl_common"]
+	path = autosklearn/automl_common
+	url = https://github.com/automl/automl_common

CONTRIBUTING.md

@@ -30,17 +30,24 @@ Following that we'll tell you about how you can test your changes locally and th
     It's important to work off the latest changes on the **development** branch.
     ```bash
     # With https
-    git clone https://github.com/your-username/auto-sklearn
+    # Note the --recurse-submodules args, we use a submodule autosklearn/automl_common
+    # so it needs to be downloaded too
+    git clone --recurse-submodules https://github.com/your-username/auto-sklearn
 
     # ... or with ssh
-    git clone [email protected]:your-username/auto-sklearn.git
+    git clone --recurse-submodules [email protected]:your-username/auto-sklearn.git
 
     # Navigate into the cloned repo
     cd auto-sklearn
 
     # Create a new branch based off the development one
     git checkout -b my_new_branch development
 
+    # If you missed the --recurse-submodules arg during clone or need to install the
+    # submodule manually, then execute the following line:
+    #
+    # git submodule udate --init --recursive
+
     # ... Alternatively, if you would prefer a more manual method
     # Show all the available branches with a * beside your current one
     git branch
@@ -50,6 +57,11 @@ Following that we'll tell you about how you can test your changes locally and th
 
     # Create a new branch based on the currently active branch
     git checkout -b my_new_branch
+
+    # If you missed the --recurse-submodules arg during clone or need to install the
+    # submodule manually, then execute the following line:
+    #
+    # git submodule udate --init --recursive
     ```
 
     The reason to create a new branch is two fold:
@@ -335,6 +347,9 @@ Lastly, if the feature really is a game changer or you're very proud of it, cons
     cd auto-sklearn
     git checkout -b my_new_branch development
 
+    # Initialize autosklearn/automl_common submodule
+    git submodule update --init --recursive
+
     # Create a virtual environment and activate it so there are no package
     # conflicts
     python -m venv my-virtual-env

MANIFEST.in

@@ -1,9 +1,17 @@
-recursive-include autosklearn/metalearning/files *.arff
-recursive-include autosklearn/metalearning/files *.csv
-recursive-include autosklearn/metalearning/files *.txt
-include autosklearn/util/logging.yaml
+include LICENSE.txt
 include requirements.txt
+include autosklearn/util/logging.yaml
 include autosklearn/requirements.txt
-recursive-include autosklearn/experimental/ *.json
-include autosklearn/experimental/askl2_training_data.json
-include LICENSE.txt
+
+# Meta-data
+recursive-include autosklearn/metalearning/files *.arff *.csv *.txt
+recursive-include autosklearn/experimental *.json
+
+# Remove tests from automl_common
+prune autosklearn/automl_common/test
+exclude autosklearn/automl_common/setup.py
+
+# Include automl_common LICENSE and README
+include autosklearn/automl_common/LICENSE
+include autosklearn/automl_common/README.md
+

autosklearn/automl.py

@@ -38,6 +38,8 @@
 from sklearn.metrics._classification import type_of_target
 from sklearn.dummy import DummyClassifier, DummyRegressor
 
+from autosklearn.automl_common.common.utils.backend import Backend, create
+
 from autosklearn.metrics import Scorer, default_metric_for_task
 from autosklearn.data.xy_data_manager import XYDataManager
 from autosklearn.data.validation import (
@@ -50,7 +52,6 @@
 from autosklearn.evaluation.abstract_evaluator import _fit_and_suppress_warnings
 from autosklearn.evaluation.train_evaluator import TrainEvaluator, _fit_with_budget
 from autosklearn.metrics import calculate_metric
-from autosklearn.util.backend import Backend, create
 from autosklearn.util.stopwatch import StopWatch
 from autosklearn.util.logging_ import (
     setup_logger,
@@ -281,6 +282,8 @@ def __init__(self,
     def _create_backend(self) -> Backend:
         return create(
             temporary_directory=self._temporary_directory,
+            output_directory=None,
+            prefix="auto-sklearn",
             delete_tmp_folder_after_terminate=self._delete_tmp_folder_after_terminate,
         )