make interface more robust

Author: moriyak

lib/html-table-parser.test.ts

@@ -1,4 +1,8 @@
-import { parseTable, getElementPositionInTable } from "./html-table-parser"
+import {
+  parseTable,
+  getElementPositionInCellMatrix,
+  createCellMatrix
+} from "./html-table-parser"
 
 const cases = [
   {
@@ -273,7 +277,8 @@ describe("getElementPositionInTable", () => {
     <tr><td>3</td><td>4</tr>
     `)
     const cell = table.querySelectorAll("td")[3]
-    expect(getElementPositionInTable(table, cell)).toStrictEqual({
+    const matrix = createCellMatrix(table)
+    expect(getElementPositionInCellMatrix(matrix, cell)).toStrictEqual({
       x: 1,
       y: 1
     })

lib/html-table-parser.ts

@@ -2,10 +2,14 @@ type RowElement = HTMLTableRowElement
 type CellElement = HTMLTableHeaderCellElement | HTMLTableCellElement
 
 export function parseTable(tableElement: HTMLTableElement) {
+  return parseCellMatrix(createCellMatrix(tableElement))
+}
+
+export function parseCellMatrix(cellMatrix: CellElement[][]) {
   let elementList = []
   let parsedInfoList = []
 
-  return createCellMatrix(tableElement).map((row, rowIndex) =>
+  return cellMatrix.map((row, rowIndex) =>
     row.map((cell, colIndex) => {
       let index = elementList.indexOf(cell)
       if (index === -1) {
@@ -30,13 +34,12 @@ export function parseTable(tableElement: HTMLTableElement) {
   )
 }
 
-export function getElementPositionInTable(
-  tableElement: HTMLTableElement,
+export function getElementPositionInCellMatrix(
+  cellMatrix: CellElement[][],
   cellElement: CellElement
 ) {
-  const matrix = createCellMatrix(tableElement)
-  for (let y = 0; y < matrix.length; y++) {
-    const row = matrix[y]
+  for (let y = 0; y < cellMatrix.length; y++) {
+    const row = cellMatrix[y]
     for (let x = 0; x < row.length; x++) {
       if (row[x] === cellElement) {
         return { x, y }
@@ -57,7 +60,9 @@ Normalize table structure considering colspan and rowspan.
 |       |   D   |
 +-------+-------+
 */
-function createCellMatrix(tableElement: HTMLTableElement) {
+export function createCellMatrix(
+  tableElement: HTMLTableElement
+): CellElement[][] {
   const rows = [tableElement.tHead]
     .concat(Array.from(tableElement.tBodies))
     .concat(tableElement.tFoot)

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@autifyhq/html-table-parser",
-  "version": "0.0.2",
+  "version": "0.0.3",
   "description": "Parse html tables and convert to json",
   "source": "lib/html-table-parser.ts",
   "main": "dist/html-table-parser.js",