Skip to content

Commit cf31b12

Browse files
tomasgareauaudunhov
authored andcommitted
fix: prevent mason setup from being run twice (nvim-lua#1298)
* fix: prevent mason setup from being run twice Addresses nvim-lua#1297 Currently, we're calling `require('mason').setup(...)` twice: * once when setting it as a dependency of `nvim-lspconfig` (since we set `config = true`) * once in the `config` function we define for `nvim-lspconfig` Calling setup twice can cause issues with, e.g., setting the `PATH` option: you might append Mason's bin dir in one setup call and prepend it in the other. We've kept the setup of `mason` in the `nvim-lspconfig` dependencies table since leaving it to the `config` function caused some plugin-loading-order related issues in the past. See: * nvim-lua#210 * nvim-lua#554 * nvim-lua#555 * nvim-lua#865 * docs: tweak comments per review feedback
1 parent 68e9280 commit cf31b12

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

init.lua

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,9 @@ require('lazy').setup({
374374
'neovim/nvim-lspconfig',
375375
dependencies = {
376376
-- Automatically install LSPs and related tools to stdpath for Neovim
377-
{ 'williamboman/mason.nvim', config = true }, -- NOTE: Must be loaded before dependants
377+
-- Mason must be loaded before its dependents so we need to set it up here.
378+
-- NOTE: `opts = {}` is the same as calling `require('mason').setup({})`
379+
{ 'williamboman/mason.nvim', opts = {} },
378380
'williamboman/mason-lspconfig.nvim',
379381
'WhoIsSethDaniel/mason-tool-installer.nvim',
380382

@@ -563,13 +565,16 @@ require('lazy').setup({
563565
}
564566

565567
-- Ensure the servers and tools above are installed
566-
-- To check the current status of installed tools and/or manually install
567-
-- other tools, you can run
568+
--
569+
-- To check the current status of installed tools and/or manually install
570+
-- other tools, you can run
568571
-- :Mason
569572
--
570-
-- You can press `g?` for help in this menu.
571-
require('mason').setup()
572-
573+
-- You can press `g?` for help in this menu.
574+
--
575+
-- `mason` had to be setup earlier: to configure its options see the
576+
-- `dependencies` table for `nvim-lspconfig` above.
577+
--
573578
-- You can add other tools here that you want Mason to install
574579
-- for you, so that they are available from within Neovim.
575580
local ensure_installed = vim.tbl_keys(servers or {})

0 commit comments

Comments
 (0)