fix: use Map instead of object for minimap subscriptions

Author: aminya

lib/minimap-find-and-replace.js

@@ -11,8 +11,8 @@ module.exports = {
 	activate (state) {
 		this.active = false
 		this.fnrVisible = false
-		this.bindingsById = {}
-		this.subscriptionsById = {}
+		this.bindingsById = new Map()
+		this.subscriptionsById = new Map()
 		this.subscriptions = new CompositeDisposable()
 		require('atom-package-deps').install('minimap-find-and-replace')
 	},
@@ -46,23 +46,23 @@ module.exports = {
 					MinimapFindAndReplaceBinding = require('./minimap-find-and-replace-binding')
 				}
 
-				const {
-					id,
-				} = minimap
+				const { id } = minimap
 				const binding = new MinimapFindAndReplaceBinding(minimap, fnr, this.fnrVisible)
-				this.bindingsById[id] = binding
-
-				this.subscriptionsById[id] = minimap.onDidDestroy(() => {
-					if (this.subscriptionsById[id]) {
-						this.subscriptionsById[id].dispose()
-					}
-					if (this.bindingsById[id]) {
-						this.bindingsById[id].destroy()
-					}
-
-					delete this.bindingsById[id]
-					delete this.subscriptionsById[id]
-				})
+				this.bindingsById.set(id, binding)
+
+				this.subscriptionsById.set(id,
+					minimap.onDidDestroy(() => {
+						if (this.subscriptionsById.has(id)) {
+							this.subscriptionsById.get(id).dispose()
+						}
+						if (this.bindingsById.has(id)) {
+							this.bindingsById.get(id).destroy()
+						}
+
+						this.bindingsById.delete(id)
+						this.subscriptionsById.delete(id)
+					}),
+				)
 			}))
 		})
 	},
@@ -87,25 +87,28 @@ module.exports = {
 
 	changeVisible (visible) {
 		this.fnrVisible = visible
-		for (const id in this.bindingsById) {
-			this.bindingsById[id].changeVisible(visible)
+		const bindings = this.bindingsById.values()
+		for (const binding of bindings) {
+			binding.changeVisible(visible)
 		}
 	},
 
 	deactivatePlugin () {
-		let id
 		if (!this.active) {
 			return
 		}
 
 		this.active = false
 		this.subscriptions.dispose()
 
-		for (id in this.subscriptionsById) {
-			const sub = this.subscriptionsById[id]; sub.dispose()
+		const subscriptions = this.subscriptionsById.values()
+		for (const subscription of subscriptions) {
+			subscription.dispose()
 		}
-		for (id in this.bindingsById) {
-			const binding = this.bindingsById[id]; binding.destroy()
+
+		const bindings = this.bindingsById.values()
+		for (const binding of bindings) {
+			binding.destroy()
 		}
 
 		this.bindingsById = {}