Fix WriteFmtFuture not taking into account already written bytes (#964) #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #964. The problem is that
amt(amount of bytes already written) is ignored, so on every poll the whole buffer is sent again if it was not possible to write the whole buffer on the first poll. Interestingly, for some cases other thanFile, all bytes get written on the first poll, which is probably why this bug hasn't been noticed before.The actual fix is just line 44, but converting from
u64tousizefor array indexing requires a checked conversion and I couldn't see any reason in the code whyamthas to beu64, so I changed the type to avoid something liketry_into().unwrap().