Skip to content

Cleanup stream module #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Nov 11, 2019
Merged

Cleanup stream module #506

merged 3 commits into from Nov 11, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 11, 2019

  • Changed from_fn and repeat_with to take regular closures.
  • Changed some stream methods to take &mut self rather than self in order to match Iterator.
  • Added missing Clone and Debug impls.
  • Added missing stream struct exports.
  • Simplified stream types and changed them to match iterator types.
  • Changed the implementation of cycle() to match how iterators work.
  • Doc fixes, formatting, etc.

Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoshuawuyts yoshuawuyts merged commit 76c5ffe into async-rs:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant