Async combinators #262
Async combinators #262
Conversation
|
This is very exciting; thanks for putting in the work! |
|
@yoshuawuyts can we r+ #263 so this one can be updated and move on from draft? |
src/stream/stream/mod.rs
Outdated
| a.parse::<u32>().ok() | ||
| }); | ||
|
|
||
| let mut parsed = unsafe { std::pin::Pin::new_unchecked(&mut parsed) }; |
There was a problem hiding this comment.
Hm is there something we could do about the unsafe block here? Even using pin_utils might be better than what we currently have, but I'm curious why we need it?
There was a problem hiding this comment.
yep, that's must be some leftover
|
@yoshuawuyts fixed, but the |
|
Dang, it seems that CI went and broke between the last commit and the most recent one. Currently trying to fix parts of it through #280, but I'm thinking I should probably just manually run the tests on this PR to confirm things are good and then merge (: |
|
@montekki could you try rebasing on master? |
|
@montekki could you try rebasing again? -- I really want to get this to pass CI so we can merge it. |
|
@yoshuawuyts @montekki what is the state of this? |
|
@dignifiedquire this still needed? merged with master, going to do required cleanups a bit later |
|
As far as I know, this was postponed to the next major version: #496 (comment) (perhaps because async closure is incomplete) |
|
Ok no rush then. |
|
Ok, at this point I think that I'd rather re-implement it from scratch when time comes than continue attempts to update this PR so closing. |
Partially fixes #244 (Probably that issue needs to be broken down in two: 1) for what can be done now 2) what can be done in the future like async closures and taking by ref.
Also unimplements
Unpinforallandanycombinators becasue now we have a future cached that may not be unpin.