1D Wavelength Calibration and 2D tilt correction #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a sum of nearest-line distances between a theoretical line list and a transformed observed line list.
…with respect to x.
Renamed `wavecal.py` to `lswavecal1d.py` and refactored the `WavelengthSolution1D` class for improved clarity and functionality. Added new methods like `refine_fit`, `pix_to_wav`, and `wav_to_pix`, and modified existing ones to enhance flexibility and maintainability.
Introduce `WavelengthSolution2D` class for 2D wavelength calibration, extending functionality from 1D calibration.
…el and spectral frames.
… type hints, documentation, and method structure. Added new methods for calculating inverse transformations and derivatives. Enhanced plotting functionality with additional parameters and refined docstrings for clarity.
…where `arc_spectra` is `None`.
… `plim` parameter for pixel range control in plotting.
…, and modularity, while resolving associated issues. Enhanced methods for handling pixel-to-wavelength mappings, line-matching processes, and plotting capabilities. Added new functions and properties for better control over data and fit refinement.
…ns with setters to ensure proper masking and validation. Added `plot_lines_pix` and `plot_lines_wav` methods for enhanced modularity in plotting observed and theoretical lines.
…thods, updated property names, and enhanced plotting functionality.
…umentation for plotting and fitting methods.
…e maximum number of iterations for refining the pixel-to-wavelength transformation. This ensures the process adjusts until convergence or the specified iteration limit is reached.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #265 +/- ##
==========================================
+ Coverage 87.74% 90.46% +2.72%
==========================================
Files 15 17 +2
Lines 1289 1846 +557
==========================================
+ Hits 1131 1670 +539
- Misses 158 176 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ok, looks like all the builds are failing because of a matplotlib dependency that I added. I'll need to make matplotlib and the plotting functionality optional. |
|
Docs build works with Jupyter Notebook examples. Take a look at https://specreduce--265.org.readthedocs.build/en/265/wavelength_calibration/wavelength_calibration.html |
… without matplotlib installed.
…, and functionality. Added detailed docstrings, refined methods for arc line identification, transformation fitting, and matching lines. Improved internal handling of parameters and optimized logic.
…onsistency and improved usability. Updated variable names and docstrings for better clarity and alignment with the code's functionality. Simplified return behavior in `match_lines` to support optional concatenation.
…xibility in 2D spectrum rectification. Updated methods to use these parameters, ensuring proper alignment and control over mask handling. Also improved documentation and refactored variable naming.
…uns, but must be improved to ensure that the results are correct.
hpparvi
changed the title
hpparvi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new 1D wavelength calibration class,
specreduce.wavecal1d.WavelengthCalibration1D, intended to fully replace the existingspecreduce.wavelength_calibration.WavelengthCalibration1Din version 2.0 (I'm keeping the previous class for backwards compatibility), and a new tilt correction class for 2D tilt correction. It also includes documentation demonstrating how to use the class for both interactive and automated wavelength calibration workflows.The core functionality is ready for review. I still need to tidy up some of the docstrings and ensure the ReadTheDocs configuration correctly supports Jupyter notebooks, but otherwise everything is in place. Feel free to test it out and let me know if you run into any issues.
The only (somewhat) significant feature currently missing is support for generating standard spectroscopic
-GRIand-GRAWCSs as described in Greisen et al. (2006). At the moment, the class supports only GWCS-based WCS. This is something we can address in a future update.