Add option to use different reference arrays for derived test classes #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously tests could not be inherited from classes in a way that let each class save its own array. This change makes the file written use the full test name, including the class name, instead of just the test name within the class.
|
Thanks. I noticed that CI was disabled due to inactivity. I just re-enabled it but will have to close/reopen to trigger. Please do not be alarmed. |
pllim
reviewed
May 21, 2025
|
|
||
| def test_derived_fails(): | ||
|
|
||
| tmpdir = tempfile.mkdtemp() |
There was a problem hiding this comment.
Can probably just use tmp_path fixture? https://docs.pytest.org/en/stable/how-to/tmp_path.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously tests could not be inherited from classes in a way that let each class save its own array. This change makes the file written use the full test name, including the class name, instead of just the test name within the class.
This use case came up in a project I'm working on right now. The overall use case is to create a base class with tests that use class variables (It must not start with Test or Pytest will try to run its tests directly), then derive new Test classes from that class with different data. This is a normal Pytest workflow, but before this change Arraydiff would use the same name for each saved array, see the failing test case. It does not change default behavior, and adds this behavior when the "derive_classes" kwarg is added to the Arraydiff mark.
I think this change is nearly complete, but it might be worth revising the naming convention. I also notice that the Windows CI tests currently fail in a way that I haven't been able to diagnose, I'd appreciate some help figuring fixing those.