Remove astropy dependency #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olebole
force-pushed
the
remove-astropy-dependency
branch
from
1b959d0 to
a12ff05
Compare
This removal breaks the circular dependency astropy --> pytest-astropy --> pytest-arraydiff which may be problematic when upgrading or so. It also eases the use of pytest-arraydiff in non-astropy environments. Astropy is only needed to compare FITS files.
olebole
force-pushed
the
remove-astropy-dependency
branch
from
a12ff05 to
61da138
Compare
Member
|
I pushed a commit to install astropy during testing. FYI. |
pllim
approved these changes
Jan 6, 2022
Member
pllim
left a comment
pllim
left a comment
There was a problem hiding this comment.
Provided CI passes. I think this makes sense. Thanks!
Member
Author
|
@plim Thanks! This is where I struggled now. |
Member
|
Do you need a new release with this patch? 👀 |
Member
Author
|
No, I already made a new Debian package including the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removal breaks the circular dependency
astropy ---> pytest-astropy ---> pytest-arraydiff
which may be problematic when upgrading or so. It also eases the use of pytest-arraydiff in non-astropy environments. Astropy is only needed to compare FITS files.
The plugin itself is already prepared (it imports astropy only when needed).
Relevant Debian bug: Debian#1003238