Make sure test matrix is consistent

across the board and add the codestyle check.

Fix PEP 8 complaints.

Auto-cancel duplicate Action jobs.

Author: pllim

.github/workflows/ci_workflows.yml

@@ -7,11 +7,16 @@ on:
     # Run every Sunday at 06:53 UTC
     - cron: 53 6 * * 0
 
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
 jobs:
   tests:
     uses: OpenAstronomy/github-actions-workflows/.github/workflows/tox.yml@v1
     with:
       envs: |
+        - linux: codestyle
         - linux: py37-test-pytestoldest
         - macos: py37-test-pytest50
         - windows: py38-test-pytest52
@@ -24,7 +29,7 @@ jobs:
         - linux: py310-test-pytest72
         - macos: py310-test-pytest73
         - windows: py311-test-pytest74
-        - linux: py312-test-pytestdev
+        - linux: py312-test-devdeps
   publish:
     needs: tests
     uses: OpenAstronomy/github-actions-workflows/.github/workflows/publish_pure_python.yml@v1

pytest_arraydiff/plugin.py

@@ -28,9 +28,6 @@
 #
 #   https://github.com/astrofrog/pytest-mpl
 
-
-from functools import wraps
-
 import os
 import abc
 import shutil
@@ -149,7 +146,7 @@ def read(filename):
 
     @staticmethod
     def write(filename, data, **kwargs):
-        import pandas as pd
+        import pandas as pd  # noqa: F401
         key = os.path.basename(filename).replace('.h5', '')
         return data.to_hdf(filename, key, **kwargs)
 
@@ -201,7 +198,7 @@ def pytest_addoption(parser):
 def pytest_configure(config):
     config.getini('markers').append(
         'array_compare: for functions using array comparison')
-    
+
     if config.getoption("--arraydiff") or config.getoption("--arraydiff-generate-path") is not None:
 
         reference_dir = config.getoption("--arraydiff-reference-path")

setup.cfg

@@ -16,6 +16,8 @@ classifiers =
     Programming Language :: Python :: 3.8
     Programming Language :: Python :: 3.9
     Programming Language :: Python :: 3.10
+    Programming Language :: Python :: 3.11
+    Programming Language :: Python :: 3.12
     Programming Language :: Python :: Implementation :: CPython
     Topic :: Software Development :: Testing
     Topic :: Utilities

tox.ini

@@ -1,6 +1,6 @@
 [tox]
 envlist =
-    py{37,38,39,310,311}-test{,-devdeps}
+    py{37,38,39,310,311,312}-test{,-pytestoldest,-pytest50,-pytest52,-pytest53,-pytest60,-pytest61,-pytest62,-pytest70,-pytest71,-pytest72,-pytest73,-pytest74,-devdeps}
     codestyle
 requires =
     setuptools >= 30.3.0
@@ -10,8 +10,7 @@ isolated_build = true
 [testenv]
 changedir = .tmp/{envname}
 setenv =
-    # Until a released numpy version is 3.12 compatible, we install the dev wheel
-    py312: PIP_EXTRA_INDEX_URL = https://pypi.anaconda.org/scientific-python-nightly-wheels/simple
+    devdeps: PIP_EXTRA_INDEX_URL = https://pypi.anaconda.org/scientific-python-nightly-wheels/simple
 description = run tests
 deps =
     pytestoldest: pytest==4.6.0
@@ -26,17 +25,20 @@ deps =
     pytest72: pytest==7.2.*
     pytest73: pytest==7.3.*
     pytest74: pytest==7.4.*
-    pytestdev: git+https://github.com/pytest-dev/pytest#egg=pytest
-    py312: numpy>=0.0.dev0
+    devdeps: git+https://github.com/pytest-dev/pytest#egg=pytest
+    devdeps: numpy>=0.0.dev0
 extras =
     test
 commands =
+    # Force numpy-dev after something in the stack downgrades it
+    devdeps: python -m pip install --pre --upgrade --extra-index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple numpy
     pip freeze
     pytest {toxinidir}/tests {posargs}
     pytest {toxinidir}/tests --arraydiff {posargs}
 
 [testenv:codestyle]
 skip_install = true
+changedir = {toxinidir}
 description = check code style, e.g. with flake8
 deps = flake8
 commands = flake8 pytest_arraydiff --count