Skip to content

Floating point "closeness" predicate #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
epage opened this issue Mar 28, 2018 · 2 comments
Closed

Floating point "closeness" predicate #11

epage opened this issue Mar 28, 2018 · 2 comments
Labels
enhancement Improve the expected

Comments

@epage
Copy link
Contributor

epage commented Mar 28, 2018

This isn't needed for any of my cases but just wanted to bring it up for rounding things out.

Floating point equality is weird. Generally, its best to do a "closeness" check.
@epage
Copy link
Contributor Author

epage commented Mar 28, 2018

Hamcrest seems to have this
https://github.com/ujh/hamcrest-rust/blob/master/src/matchers/close_to.rs

@epage epage added the enhancement Improve the expected label Mar 28, 2018
@epage
Copy link
Contributor Author

epage commented Apr 1, 2018

float_cmp might be useful for this
https://mikedilger.github.io/float-cmp/float_cmp/index.html

See also

epage added a commit to epage/predicates-rs that referenced this issue Apr 1, 2018
@epage
feat(float): is_close Predicate
49abc8c 
Fixes assert-rs#11
epage added a commit to epage/predicates-rs that referenced this issue Apr 1, 2018
@epage
feat(float): is_close Predicate
0f45f4e 
Fixes assert-rs#11
epage added a commit to epage/predicates-rs that referenced this issue Apr 2, 2018
@epage
feat(float): is_close Predicate
741d005 
Fixes assert-rs#11
epage added a commit to epage/predicates-rs that referenced this issue Apr 2, 2018
@epage
feat(float): is_close Predicate
6ee9200 
Fixes assert-rs#11
@epage epage closed this as completed in 6b646af Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve the expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epage