This repository was archived by the owner on Dec 29, 2021. It is now read-only.
Run and add rustfmt #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's wait for #46 before merging. Rebasing and reformatting this is trivial. |
epage
approved these changes
Oct 9, 2017
|
@killercup you can merge this PR, I will rebase mine ( #46 ) after that. I can also add coveralls to have more details about code coverage as well. here's an example of how it works with travis: https://github.com/Freyskeyd/Rundeck/blob/master/.travis.yml |
This better work, or I'll just remove the condition!
Freyskeyd
approved these changes
Oct 10, 2017
|
Oh, I didn't realize the binaries were cached as well. Fine. Let's be clever. @Freyskeyd, I removed coveralls in 9d81ed8 because the data wasn't very good. Maybe that changed? |
|
@killercup Dunno if change, I didn't get any trouble. |
|
You are welcome to add it again with the same tokens as in the linked commit and see if it's helpful :) But in the meantime: bors r+ |
Build succeeded |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.