Back-port infrastructure changes and source reorganization #1493
Conversation
|
FYI @jkotalik - we'll probably want to backport ANCM installers too. |
| - powershell: > | ||
| src/Installers/Windows/build.ps1 | ||
| -x64 artifacts/runtime/aspnetcore-runtime-internal-2.1.6-servicing-$(Build.BuildNumber)-win-x64.zip | ||
| -x86 artifacts/runtime/aspnetcore-runtime-internal-2.1.6-servicing-$(Build.BuildNumber)-win-x86.zip |
There was a problem hiding this comment.
Are these two supposed to have hard-coded patch versions?
There was a problem hiding this comment.
It's gross that they're hard coded here. Removing this is what I mean by "TODO: configure harvesting to run as a part of build.cmd"
I definitely consider this VSTS build definition a WIP. It doesn't produce anything official yet. I added it here because it's useful to have something even if incomplete so we can occasionally keep trying VSTS builds to see if progress is being made on BYOC and other features.
.azure/pipelines/ci-official.yml
Outdated
| signType: $(_SignType) | ||
| zipSources: false | ||
| # TODO: configure build.cmd to build both x64 and x86 in one invocation | ||
| # TODO build.cmd -ci |
There was a problem hiding this comment.
Are these two TODO comments still valid? If so, should they be tracked in a bug?
There was a problem hiding this comment.
And all the other TODOs in other yamls.
There was a problem hiding this comment.
Most TODOs are still valid. The -ci flag one isn't anymore. I'll remove this now.
There was a problem hiding this comment.
Do we want/need any issues to track the work? I just want to make sure we don't forget anything important.
There was a problem hiding this comment.
We have issues tracking this work. I'd lump these TODOs generally under https://github.com/aspnet/AspNetCore-Internal/issues/876
* Add build definition for Azure DevOps * Put code for metapackages in a subfolder * Update targets to prepare for submodules merging into this repo * Add source code for windows installer * Add source code for Debian installers
natemcmaster
force-pushed
the
namc/backport
branch
from
2fb6e9b to
fb3f5d9
Compare
This is preparation for beginning to merge in some git submodules per dotnet/aspnetcore#3598.
These changes have already been made in the release/2.2 and master branches. This back-ports those changes to 2.1.