Skip to content
This repository was archived by the owner on Oct 18, 2018. It is now read-only.

wip: Add a package dependency from Microsoft.AspNetCore.App/All to NETCore.App #1261

Closed
wants to merge 1 commit into from
Closed

wip: Add a package dependency from Microsoft.AspNetCore.App/All to NETCore.App #1261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Microsoft.AspNetCore.All/Microsoft.AspNetCore.All.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<PackageTags>aspnetcore</PackageTags>
<Description>Microsoft.AspNetCore.All</Description>
<EnableApiCheck>false</EnableApiCheck>
<DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences>
</PropertyGroup>

<ItemGroup>
Expand All @@ -15,4 +16,8 @@
<Content Include="lib\$(TargetFramework)\_._" PackagePath="%(Identity)" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NETCore.App" Version="$(RuntimeFrameworkVersion)" PrivateAsset="None" />
</ItemGroup>

</Project>
5 changes: 5 additions & 0 deletions src/Microsoft.AspNetCore.App/Microsoft.AspNetCore.App.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<PackageTags>aspnetcore</PackageTags>
<Description>Microsoft.AspNetCore.App</Description>
<EnableApiCheck>false</EnableApiCheck>
<DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences>
</PropertyGroup>

<ItemGroup>
Expand All @@ -15,4 +16,8 @@
<Content Include="lib\$(TargetFramework)\_._" PackagePath="%(Identity)" />
</ItemGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NETCore.App" Version="[$(RuntimeFrameworkVersion), 2.2.0)" PrivateAsset="None" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version would we need to target? The bundled version (latest patch) or the pinned version (major.minor.0)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add this at all, it should be latest patch. Otherwise, adding this only creates problems and doesn't solve any.

</ItemGroup>

</Project>