Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

[2.1.1] Bump package versions #2363

Merged
merged 2 commits into from
May 29, 2018
Merged

[2.1.1] Bump package versions #2363

merged 2 commits into from
May 29, 2018

Conversation

natemcmaster
Copy link
Contributor

No description provided.

@natemcmaster
Copy link
Contributor Author

I'll merge this PR once release/2.1 branches are open for 2.1.1 changes. Until then, leaving this open as "SHP: pending approval".

@natemcmaster
Copy link
Contributor Author

@anurse is any manual action required to also update the npm package to 1.0.1?

@analogrelay
Copy link
Contributor

Maybe. Let me take a look

@analogrelay
Copy link
Contributor

Looks like we're good. We use the PackageVersion msbuild variable to fill it in, so as long as that is set correctly we're good. Probably not a bad idea to update the package.json files but the build process overwrites the value within the package.json anyway.

image

@analogrelay
Copy link
Contributor

analogrelay commented May 24, 2018

I pushed a commit updating the package.json versions, just because it makes it all consistent. As I said, it's not mandatory to do this in order to make the package versions correct.

@natemcmaster
Copy link
Contributor Author

Thanks

@natemcmaster natemcmaster merged commit ad55661 into release/2.1 May 29, 2018
@natemcmaster natemcmaster deleted the namc/2.1.1 branch May 29, 2018 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants