Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Commit cf99250

Browse files
TratcherJunTaoLuo
authored andcommitted
SameSiteMode.None for OIDC & CorellationId
1 parent 2cb0135 commit cf99250

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

samples/OpenIdConnect.AzureAdSample/Program.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ public static void Main(string[] args)
1515
factory.AddFilter("Console", level => level >= LogLevel.Information);
1616
})
1717
.UseKestrel()
18+
.UseUrls("http://localhost:42023")
1819
.UseContentRoot(Directory.GetCurrentDirectory())
1920
.UseIISIntegration()
2021
.UseStartup<Startup>()

src/Microsoft.AspNetCore.Authentication.OpenIdConnect/OpenIdConnectHandler.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -892,7 +892,7 @@ private void WriteNonceCookie(string nonce)
892892
new CookieOptions
893893
{
894894
HttpOnly = true,
895-
SameSite = Http.SameSiteMode.Lax,
895+
SameSite = Http.SameSiteMode.None,
896896
Secure = Request.IsHttps,
897897
Expires = Clock.UtcNow.Add(Options.ProtocolValidator.NonceLifetime)
898898
});
@@ -924,7 +924,7 @@ private string ReadNonceCookie(string nonce)
924924
var cookieOptions = new CookieOptions
925925
{
926926
HttpOnly = true,
927-
SameSite = Http.SameSiteMode.Lax,
927+
SameSite = Http.SameSiteMode.None,
928928
Secure = Request.IsHttps
929929
};
930930

src/Microsoft.AspNetCore.Authentication/RemoteAuthenticationHandler.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ protected virtual void GenerateCorrelationId(AuthenticationProperties properties
203203
var cookieOptions = new CookieOptions
204204
{
205205
HttpOnly = true,
206-
SameSite = SameSiteMode.Lax,
206+
SameSite = SameSiteMode.None,
207207
Secure = Request.IsHttps,
208208
Expires = Clock.UtcNow.Add(Options.RemoteAuthenticationTimeout),
209209
};
@@ -243,7 +243,7 @@ protected virtual bool ValidateCorrelationId(AuthenticationProperties properties
243243
var cookieOptions = new CookieOptions
244244
{
245245
HttpOnly = true,
246-
SameSite = SameSiteMode.Lax,
246+
SameSite = SameSiteMode.None,
247247
Secure = Request.IsHttps
248248
};
249249
Response.Cookies.Delete(cookieName, cookieOptions);

0 commit comments

Comments
 (0)