Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Commit 2cb0135

Browse files
committed
Feedbackg
1 parent ad70b21 commit 2cb0135

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/Microsoft.AspNetCore.Authentication.OpenIdConnect/OpenIdConnectHandler.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public OpenIdConnectHandler(IOptionsSnapshot<OpenIdConnectOptions> options, ILog
6262
}
6363

6464
/// <summary>
65-
/// The handler calls methods on the events which give the application control at certain points where processing is occurring.
65+
/// The handler calls methods on the events which give the application control at certain points where processing is occurring.
6666
/// If it is not provided a default instance is supplied which does nothing when the methods are called.
6767
/// </summary>
6868
protected new OpenIdConnectEvents Events
@@ -892,7 +892,7 @@ private void WriteNonceCookie(string nonce)
892892
new CookieOptions
893893
{
894894
HttpOnly = true,
895-
SameSite = Http.SameSiteMode.Strict,
895+
SameSite = Http.SameSiteMode.Lax,
896896
Secure = Request.IsHttps,
897897
Expires = Clock.UtcNow.Add(Options.ProtocolValidator.NonceLifetime)
898898
});
@@ -924,7 +924,7 @@ private string ReadNonceCookie(string nonce)
924924
var cookieOptions = new CookieOptions
925925
{
926926
HttpOnly = true,
927-
SameSite = Http.SameSiteMode.Strict,
927+
SameSite = Http.SameSiteMode.Lax,
928928
Secure = Request.IsHttps
929929
};
930930

src/Microsoft.AspNetCore.Authentication.Twitter/TwitterHandler.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ internal class TwitterHandler : RemoteAuthenticationHandler<TwitterOptions>
3131
private HttpClient Backchannel => Options.Backchannel;
3232

3333
/// <summary>
34-
/// The handler calls methods on the events which give the application control at certain points where processing is occurring.
34+
/// The handler calls methods on the events which give the application control at certain points where processing is occurring.
3535
/// If it is not provided a default instance is supplied which does nothing when the methods are called.
3636
/// </summary>
3737
protected new TwitterEvents Events
@@ -83,7 +83,7 @@ protected override async Task<AuthenticateResult> HandleRemoteAuthenticateAsync(
8383
var cookieOptions = new CookieOptions
8484
{
8585
HttpOnly = true,
86-
SameSite = SameSiteMode.Strict,
86+
SameSite = SameSiteMode.Lax,
8787
Secure = Request.IsHttps
8888
};
8989

@@ -154,7 +154,7 @@ protected override async Task HandleChallengeAsync(AuthenticationProperties prop
154154
var cookieOptions = new CookieOptions
155155
{
156156
HttpOnly = true,
157-
SameSite = SameSiteMode.Strict,
157+
SameSite = SameSiteMode.Lax,
158158
Secure = Request.IsHttps,
159159
Expires = Clock.UtcNow.Add(Options.RemoteAuthenticationTimeout),
160160
};

src/Microsoft.AspNetCore.Authentication/RemoteAuthenticationHandler.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212

1313
namespace Microsoft.AspNetCore.Authentication
1414
{
15-
public abstract class RemoteAuthenticationHandler<TOptions> : AuthenticationHandler<TOptions>, IAuthenticationRequestHandler
15+
public abstract class RemoteAuthenticationHandler<TOptions> : AuthenticationHandler<TOptions>, IAuthenticationRequestHandler
1616
where TOptions : RemoteAuthenticationOptions, new()
1717
{
1818
private const string CorrelationPrefix = ".AspNetCore.Correlation.";
@@ -25,7 +25,7 @@ public abstract class RemoteAuthenticationHandler<TOptions> : AuthenticationHand
2525
protected string SignInScheme => Options.SignInScheme;
2626

2727
/// <summary>
28-
/// The handler calls methods on the events which give the application control at certain points where processing is occurring.
28+
/// The handler calls methods on the events which give the application control at certain points where processing is occurring.
2929
/// If it is not provided a default instance is supplied which does nothing when the methods are called.
3030
/// </summary>
3131
protected new RemoteAuthenticationEvents Events
@@ -203,7 +203,7 @@ protected virtual void GenerateCorrelationId(AuthenticationProperties properties
203203
var cookieOptions = new CookieOptions
204204
{
205205
HttpOnly = true,
206-
SameSite = SameSiteMode.Strict,
206+
SameSite = SameSiteMode.Lax,
207207
Secure = Request.IsHttps,
208208
Expires = Clock.UtcNow.Add(Options.RemoteAuthenticationTimeout),
209209
};
@@ -243,7 +243,7 @@ protected virtual bool ValidateCorrelationId(AuthenticationProperties properties
243243
var cookieOptions = new CookieOptions
244244
{
245245
HttpOnly = true,
246-
SameSite = SameSiteMode.Strict,
246+
SameSite = SameSiteMode.Lax,
247247
Secure = Request.IsHttps
248248
};
249249
Response.Cookies.Delete(cookieName, cookieOptions);

0 commit comments

Comments
 (0)