Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Commit 1ce9a52

Browse files
committed
Consolidate to use SameSiteMode
1 parent c6db8e0 commit 1ce9a52

File tree

4 files changed

+14
-26
lines changed

4 files changed

+14
-26
lines changed

src/Microsoft.AspNetCore.CookiePolicy/CookiePolicyMiddleware.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ public IResponseCookies Cookies
7474

7575
private bool PolicyRequiresCookieOptions()
7676
{
77-
return Policy.SameSite != MinimumSameSiteStrictnessPolicy.None || Policy.HttpOnly != HttpOnlyPolicy.None || Policy.Secure != CookieSecurePolicy.None;
77+
return Policy.MinimumSameSitePolicy != SameSiteMode.None || Policy.HttpOnly != HttpOnlyPolicy.None || Policy.Secure != CookieSecurePolicy.None;
7878
}
7979

8080
public void Append(string key, string value)
@@ -151,21 +151,21 @@ private void ApplyPolicy(CookieOptions options)
151151
default:
152152
throw new InvalidOperationException();
153153
}
154-
switch (Policy.SameSite)
154+
switch (Policy.MinimumSameSitePolicy)
155155
{
156-
case MinimumSameSiteStrictnessPolicy.None:
156+
case SameSiteMode.None:
157157
break;
158-
case MinimumSameSiteStrictnessPolicy.Lax:
158+
case SameSiteMode.Lax:
159159
if (options.SameSite == SameSiteMode.None)
160160
{
161161
options.SameSite = SameSiteMode.Lax;
162162
}
163163
break;
164-
case MinimumSameSiteStrictnessPolicy.Strict:
164+
case SameSiteMode.Strict:
165165
options.SameSite = SameSiteMode.Strict;
166166
break;
167167
default:
168-
throw new InvalidOperationException($"Unrecognized {nameof(MinimumSameSiteStrictnessPolicy)} value {Policy.SameSite.ToString()}");
168+
throw new InvalidOperationException($"Unrecognized {nameof(SameSiteMode)} value {Policy.MinimumSameSitePolicy.ToString()}");
169169
}
170170
switch (Policy.HttpOnly)
171171
{

src/Microsoft.AspNetCore.CookiePolicy/CookiePolicyOptions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class CookiePolicyOptions
1515
/// <summary>
1616
/// Affects the cookie's same site attribute.
1717
/// </summary>
18-
public MinimumSameSiteStrictnessPolicy SameSite { get; set; } = MinimumSameSiteStrictnessPolicy.Strict;
18+
public SameSiteMode MinimumSameSitePolicy { get; set; } = SameSiteMode.Strict;
1919

2020
/// <summary>
2121
/// Affects whether cookies must be HttpOnly.

src/Microsoft.AspNetCore.CookiePolicy/SameSitePolicy.cs

Lines changed: 0 additions & 12 deletions
This file was deleted.

test/Microsoft.AspNetCore.CookiePolicy.Test/CookiePolicyTests.cs

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ public async Task SameSiteStrictSetsItAlways()
161161
await RunTest("/sameSiteStrict",
162162
new CookiePolicyOptions
163163
{
164-
SameSite = MinimumSameSiteStrictnessPolicy.Strict
164+
MinimumSameSitePolicy = Http.SameSiteMode.Strict
165165
},
166166
SameSiteCookieAppends,
167167
new RequestTest("http://example.com/sameSiteStrict",
@@ -182,7 +182,7 @@ public async Task SameSiteLaxSetsItAlways()
182182
await RunTest("/sameSiteLax",
183183
new CookiePolicyOptions
184184
{
185-
SameSite = MinimumSameSiteStrictnessPolicy.Lax
185+
MinimumSameSitePolicy = Http.SameSiteMode.Lax
186186
},
187187
SameSiteCookieAppends,
188188
new RequestTest("http://example.com/sameSiteLax",
@@ -203,17 +203,17 @@ public async Task SameSiteNoneLeavesItAlone()
203203
await RunTest("/sameSiteNone",
204204
new CookiePolicyOptions
205205
{
206-
HttpOnly = HttpOnlyPolicy.None
206+
MinimumSameSitePolicy = Http.SameSiteMode.None
207207
},
208208
SameSiteCookieAppends,
209209
new RequestTest("http://example.com/sameSiteNone",
210210
transaction =>
211211
{
212212
Assert.NotNull(transaction.SetCookie);
213-
Assert.Equal("A=A; path=/; samesite=strict", transaction.SetCookie[0]);
214-
Assert.Equal("B=B; path=/; samesite=strict", transaction.SetCookie[1]);
215-
Assert.Equal("C=C; path=/; samesite=strict", transaction.SetCookie[2]);
216-
Assert.Equal("D=D; path=/; samesite=strict", transaction.SetCookie[3]);
213+
Assert.Equal("A=A; path=/", transaction.SetCookie[0]);
214+
Assert.Equal("B=B; path=/", transaction.SetCookie[1]);
215+
Assert.Equal("C=C; path=/; samesite=lax", transaction.SetCookie[2]);
216+
Assert.Equal("D=D; path=/; samesite=lax", transaction.SetCookie[3]);
217217
Assert.Equal("E=E; path=/; samesite=strict", transaction.SetCookie[4]);
218218
}));
219219
}

0 commit comments

Comments
 (0)