This repository was archived by the owner on Nov 22, 2018. It is now read-only.
Optimizations #87
Merged
Optimizations #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tratcher
reviewed
Dec 12, 2016
|
|
||
| public Stream Body { get; set; } | ||
|
|
||
| public string BodyLengthString { get; set; } |
There was a problem hiding this comment.
why not cache this directly in Headers like you do with Date?
JunTaoLuo
force-pushed
the
johluo/long
branch
from
ecc971c to
87aad42
Compare
Tratcher
approved these changes
Dec 14, 2016
- Calculate age using operations on long - Compute content length of resposne on store - Format age using the new HeaderUtility - Lazily create HeaderDictionary - Use for instead of foreach to reduce allocations from enumerators
JunTaoLuo
force-pushed
the
johluo/long
branch
from
87aad42 to
8e85255
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I was looking at the allocation saving on #70 I noticed a few quick optimizations.
Before: 346747.2 RPS, 1205.3 bytes/req (net451), 848.6 bytes/req (netcore)
After: 434507.1 RPS, 1158.9 bytes/req (net451), 802.8 bytes/req (netcore)
@BrennanConroy @Tratcher