This repository was archived by the owner on Nov 22, 2018. It is now read-only.
Add configurable options for ResponseCaching #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <summary> | ||
| /// Create a custom segment that is appended to the default cache key. | ||
| /// </summary> | ||
| public Func<HttpContext, string> CreateCustomizedCacheKey { get; set; } |
There was a problem hiding this comment.
We can consider passing the StringBuilder that contains the default key to the user. It may be more efficient if the user needs to concatenate many small segments since it saves creating a new instance of StringBuilder. But not sure how often this would arise and it may be a premature optimization. It would also have the side effect of the user being able to overwrite the default cache key.
There was a problem hiding this comment.
They can get a string builder from the request services caching service
There was a problem hiding this comment.
Also, interfaces prevent adding events. See aspnet/Security#942
|
🆙📅 |
JunTaoLuo
force-pushed
the
johluo/configureable-options
branch
3 times, most recently
from
763b45f to
58be8ea
Compare
Override RequestIsCacheable Override ResponseIsCacheable Append customized cache key
JunTaoLuo
force-pushed
the
johluo/configureable-options
branch
from
58be8ea to
fb724a7
Compare
|
ping |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Override RequestIsCacheable
Override ResponseIsCacheable
Append customized cache key
Will add more configurability options as features are added.