ResponseCache updates to support varyby rules #14
Conversation
|
|
||
| public void Set(string key, IResponseCacheEntry entry) | ||
| { | ||
| _cache.Set(key, DefaultResponseCacheSerializer.Serialize(entry)); |
There was a problem hiding this comment.
null checks needed to be added everywhere
There was a problem hiding this comment.
And hardening. None of these operations should throw.
| context.Response.GetTypedHeaders().CacheControl = new CacheControlHeaderValue() | ||
| { | ||
| Public = true, | ||
| MaxAge = TimeSpan.FromSeconds(10) | ||
| }; | ||
| context.Response.GetTypedHeaders().AppendList("Vary", new string[] { "Accept-Encoding", "Non-Existent" }); |
There was a problem hiding this comment.
???
context.Response.Headers["Vary"] = new string[] { "Accept-Encoding", "Non-Existent" };
JunTaoLuo
force-pushed
the
johluo/varyby
branch
from
fc22a93 to
b2812fb
Compare
JunTaoLuo
changed the title
|
🆙📅 |
| { | ||
| public int StatusCode { get; set; } | ||
|
|
||
| internal IHeaderDictionary Headers { get; set; } = new HeaderDictionary(); |
There was a problem hiding this comment.
Why are these internal and status code public?
There was a problem hiding this comment.
No particular reason, could make everything internal until there's a reason to make them public. I don't see why these would be used by anyone else other than response caching middleware.
JunTaoLuo
force-pushed
the
johluo/varyby
branch
from
03d104f to
03e3284
Compare
| using System; | ||
| using Microsoft.Extensions.Caching.Distributed; | ||
|
|
||
| namespace Microsoft.AspNetCore.ResponseCaching |
There was a problem hiding this comment.
I'll move all the storage related types (other than the interface IResponseCache) to the internal namespace and make them internal types since they shouldn't be needed outside of response caching.
|
|
after one comment
JunTaoLuo
force-pushed
the
johluo/varyby
branch
from
25f732a to
a40cc88
Compare
Updating the design of ResponseCache/ResponseCacheEntries to support varyby rules. The design of how to configure these rules and what elements to vary by have not been finalized yet.
cc @Tratcher @davidfowl