This repository was archived by the owner on Nov 22, 2018. It is now read-only.
Infrastructure and preliminary layouts #12
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we are still working out the design, I'm adding the infrastructure (for build/test) of this repo. Much of the design and implementation will likely change so I'm keeping most of @Tratcher's initial work and layout for now.
A few things I've noticed:
ResponseCacheAttribute
:This repo is likely going to be confused with the
ResponseCacheAttribute
in MVC: (https://github.com/aspnet/Mvc/blob/ee2cfa1963ee7f8195130d41330f94d4622ca89a/src/Microsoft.AspNetCore.Mvc.Core/ResponseCacheAttribute.cs). We should find a way to distinguish the two since the attribute just operates on the headers and the middleware here is described asOutputCaching
in the docs (https://docs.asp.net/en/latest/performance/caching/output.html) and will actually operate as a cache. Also, if we choose to have the middleware to actively set the headers, how will this middleware interact with the MVC attribute? Will the two components exist side by side somehow?In the initial work included in the branch, the naming is inconsistent and there are instances of
ResponseCaching*
andResponseCache*
and this should be standardized. Since the repo is constructed asResponseCachING
I started using that for now but I thinkResponseCache*
feels better API wise. For example,app.UseResponseCache()
sounds more natural thanapp.UseResponseCaching()
.cc @DamianEdwards @davidfowl @muratg