Skip to content
This repository was archived by the owner on Nov 22, 2018. It is now read-only.

Infrastructure and preliminary layouts #12

Merged
merged 3 commits into from
Jul 27, 2016
Merged

Infrastructure and preliminary layouts #12

merged 3 commits into from
Jul 27, 2016

Conversation

JunTaoLuo
Copy link
Contributor

While we are still working out the design, I'm adding the infrastructure (for build/test) of this repo. Much of the design and implementation will likely change so I'm keeping most of @Tratcher's initial work and layout for now.

A few things I've noticed:

  • Conflict with ResponseCacheAttribute:

This repo is likely going to be confused with the ResponseCacheAttribute in MVC: (https://github.com/aspnet/Mvc/blob/ee2cfa1963ee7f8195130d41330f94d4622ca89a/src/Microsoft.AspNetCore.Mvc.Core/ResponseCacheAttribute.cs). We should find a way to distinguish the two since the attribute just operates on the headers and the middleware here is described as OutputCaching in the docs (https://docs.asp.net/en/latest/performance/caching/output.html) and will actually operate as a cache. Also, if we choose to have the middleware to actively set the headers, how will this middleware interact with the MVC attribute? Will the two components exist side by side somehow?

  • Naming Cache vs Caching

In the initial work included in the branch, the naming is inconsistent and there are instances of ResponseCaching* and ResponseCache* and this should be standardized. Since the repo is constructed as ResponseCachING I started using that for now but I think ResponseCache* feels better API wise. For example, app.UseResponseCache() sounds more natural than app.UseResponseCaching().

cc @DamianEdwards @davidfowl @muratg

@dnfclas
Copy link

dnfclas commented Jul 21, 2016

Hi @JunTaoLuo, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@BrennanConroy
Copy link
Member

Xml comments needed?

@BrennanConroy
Copy link
Member

:shipit:

@JunTaoLuo
Copy link
Contributor Author

I don't think we'll have xml docs until the design is finalized

@JunTaoLuo JunTaoLuo mentioned this pull request Jul 26, 2016
34 tasks
@Tratcher
Copy link
Member

:shipit:

@JunTaoLuo JunTaoLuo merged commit 1628d42 into dev Jul 27, 2016
@JunTaoLuo JunTaoLuo deleted the johluo/initial branch July 27, 2016 17:50
@JunTaoLuo JunTaoLuo mentioned this pull request Jul 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants