This repository was archived by the owner on Nov 22, 2018. It is now read-only.
Trigger caching headers finalization on write #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
force-pushed
the
johluo/on-write
branch
from
5c3dd5c to
3ef7def
Compare
Tratcher
reviewed
Feb 6, 2017
| { | ||
| var cachedResponse = entry as CachedResponse; | ||
| if (cachedResponse != null) | ||
| { | ||
| var segmentStream = new SegmentWriteStream(StreamUtilities.BodySegmentSize); | ||
| await cachedResponse.Body.CopyToAsync(segmentStream); | ||
| // We are guaranteed to have a SegmentReadStream.CopyToAsync(SegmentWriteStream) | ||
| cachedResponse.Body.CopyToAsync(segmentStream).Wait(); |
| @@ -219,10 +214,11 @@ public class ResponseCachingMiddleware | |||
| return false; | |||
| } | |||
|
|
|||
| internal async Task FinalizeCacheHeadersAsync(ResponseCachingContext context) | |||
| private bool FinalizeCacheHeadersShouldStoreVaryByEntry(ResponseCachingContext context) | |||
There was a problem hiding this comment.
This name is a bit silly, a doc comment would be sufficient to explain the return parameter.
| @@ -327,19 +343,33 @@ public class ResponseCachingMiddleware | |||
| } | |||
| } | |||
|
|
|||
| internal Task OnResponseStartingAsync(ResponseCachingContext context) | |||
| private bool OnResponseStartingShouldFinalizeHeaders(ResponseCachingContext context) | |||
| _options.MaximumBodySize, | ||
| StreamUtilities.BodySegmentSize, | ||
| () => OnResponseStarting(context), | ||
| async () => await OnResponseStartingAsync(context)); |
|
🆙📅 |
JunTaoLuo
changed the title
Tratcher
approved these changes
Feb 8, 2017
JunTaoLuo
force-pushed
the
johluo/on-write
branch
from
d20d639 to
7190412
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#92