test response caching feature always added

Author: JunTaoLuo

test/Microsoft.AspNetCore.ResponseCaching.Tests/ResponseCachingMiddlewareTests.cs

@@ -851,38 +851,33 @@ private class FakeResponseFeature : HttpResponseFeature
             public override void OnStarting(Func<object, Task> callback, object state) { }
         }
 
-        [Fact]
-        public async Task Invoke_CacheableRequest_AddsResponseCachingFeature()
+        [Theory]
+        // If allowResponseCaching is false, other settings will not matter but are included for completeness
+        [InlineData(false, false, false)]
+        [InlineData(false, false, true)]
+        [InlineData(false, true, false)]
+        [InlineData(false, true, true)]
+        [InlineData(true, false, false)]
+        [InlineData(true, false, true)]
+        [InlineData(true, true, false)]
+        [InlineData(true, true, true)]
+        public async Task Invoke_AddsResponseCachingFeature_Always(bool allowResponseCaching, bool allowCacheLookup, bool allowCacheStorage)
         {
             var responseCachingFeatureAdded = false;
             var middleware = TestUtils.CreateTestMiddleware(next: httpContext =>
             {
                 responseCachingFeatureAdded = httpContext.Features.Get<IResponseCachingFeature>() != null;
                 return TaskCache.CompletedTask;
             },
-            policyProvider: new ResponseCachingPolicyProvider());
-
-            var context = new DefaultHttpContext();
-            context.Request.Method = HttpMethods.Get;
-            context.Features.Set<IHttpResponseFeature>(new FakeResponseFeature());
-            await middleware.Invoke(context);
-
-            Assert.True(responseCachingFeatureAdded);
-        }
-
-        [Fact]
-        public async Task Invoke_NonCacheableRequest_AddsResponseCachingFeature()
-        {
-            var responseCachingFeatureAdded = false;
-            var middleware = TestUtils.CreateTestMiddleware(next: httpContext =>
+            policyProvider: new TestResponseCachingPolicyProvider
             {
-                responseCachingFeatureAdded = httpContext.Features.Get<IResponseCachingFeature>() != null;
-                return TaskCache.CompletedTask;
-            },
-            policyProvider: new ResponseCachingPolicyProvider());
+                AllowResponseCachingValue = allowResponseCaching,
+                AllowCacheLookupValue = allowCacheLookup,
+                AllowCacheStorageValue = allowCacheStorage
+            });
 
             var context = new DefaultHttpContext();
-            context.Request.Method = HttpMethods.Post;
+            context.Features.Set<IHttpResponseFeature>(new FakeResponseFeature());
             await middleware.Invoke(context);
 
             Assert.True(responseCachingFeatureAdded);

test/Microsoft.AspNetCore.ResponseCaching.Tests/TestUtils.cs

@@ -233,15 +233,21 @@ public Task SendFileAsync(string path, long offset, long? count, CancellationTok
 
     internal class TestResponseCachingPolicyProvider : IResponseCachingPolicyProvider
     {
-        public bool AllowCacheLookup(ResponseCachingContext context) => false;
+        public bool AllowCacheLookupValue { get; set; } = false;
+        public bool AllowCacheStorageValue { get; set; } = false;
+        public bool AllowResponseCachingValue { get; set; } = false;
+        public bool IsCachedEntryFreshValue { get; set; } = true;
+        public bool IsResponseCacheableValue { get; set; } = true;
 
-        public bool AllowCacheStorage(ResponseCachingContext context) => false;
+        public bool AllowCacheLookup(ResponseCachingContext context) => AllowCacheLookupValue;
 
-        public bool AllowResponseCaching(ResponseCachingContext context) => false;
+        public bool AllowCacheStorage(ResponseCachingContext context) => AllowCacheStorageValue;
 
-        public bool IsCachedEntryFresh(ResponseCachingContext context) => true;
+        public bool AllowResponseCaching(ResponseCachingContext context) => AllowResponseCachingValue;
 
-        public bool IsResponseCacheable(ResponseCachingContext context) => true;
+        public bool IsCachedEntryFresh(ResponseCachingContext context) => IsCachedEntryFreshValue;
+
+        public bool IsResponseCacheable(ResponseCachingContext context) => IsResponseCacheableValue;
     }
 
     internal class TestResponseCachingKeyProvider : IResponseCachingKeyProvider