This repository was archived by the owner on Dec 14, 2018. It is now read-only.
[2.1]: pin dependencies to the 2.1.2 baseline #8064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
reviewed
Jul 12, 2018
build/dependencies.props
Outdated
| @@ -76,20 +97,7 @@ | |||
| <MicrosoftExtensionsTypeNameHelperSourcesPackageVersion>2.1.1</MicrosoftExtensionsTypeNameHelperSourcesPackageVersion> | |||
| <MicrosoftExtensionsValueStopwatchSourcesPackageVersion>2.1.1</MicrosoftExtensionsValueStopwatchSourcesPackageVersion> | |||
| <MicrosoftExtensionsWebEncodersPackageVersion>2.1.1</MicrosoftExtensionsWebEncodersPackageVersion> | |||
| <MicrosoftNETCoreApp20PackageVersion>2.0.0</MicrosoftNETCoreApp20PackageVersion> | |||
| <MicrosoftNETCoreApp21PackageVersion>2.1.1</MicrosoftNETCoreApp21PackageVersion> | |||
| <MicrosoftNetHttpHeadersPackageVersion>2.1.1</MicrosoftNetHttpHeadersPackageVersion> | |||
| <MicrosoftNETSdkRazorPackageVersion>2.1.1</MicrosoftNETSdkRazorPackageVersion> | |||
There was a problem hiding this comment.
Should the Sdk be unpinned? It's not referenced by runtime packages
There was a problem hiding this comment.
Is this a test-only dependency? If so, then yes, this can move up into the auto section.
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks, updated.
| </PropertyGroup> | ||
| <Import Project="$(DotNetPackageVersionPropsPath)" Condition=" '$(DotNetPackageVersionPropsPath)' != '' " /> |
There was a problem hiding this comment.
Isn't this required to update the Auto versions?
There was a problem hiding this comment.
It's still present, but it's moved up in the file.
pranavkm
approved these changes
Jul 12, 2018
This reverts our previous policy of cascading versions on all servicing updates. This moves variables into the 'pinned' section, and points them to the latest stable release (versions that were used at the time of the 2.1.2 release).
natemcmaster
force-pushed
the
namc/no-cascade
branch
from
0354049 to
d46948d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/aspnetcore#3316
This pins package versions to the 2.1.2 baseline. Universe will not override variables in the 'Pinned' section. This helps ensure that Mvc does not upgrade its dependency versions for all future patches of 2.1.