Add dotnet-razor-precompile tool #5087
Conversation
pranavkm
force-pushed
the
prkrishn/precompilation
branch
from
7aa3960 to
1c5840a
Compare
| TargetFramework, | ||
| Configuration, | ||
| outputPath: outputPath, | ||
| buildBasePath: null, |
There was a problem hiding this comment.
The output path listed in xproj is actually used as the build-base-path. Super confusing I know. Even filed an issue but I guess it's by design? :/ aspnet/Tooling#455
|
⌚ |
| }, | ||
| "dependencies": { | ||
| "Microsoft.AspNetCore.Hosting": "1.1.0-*", | ||
| "Microsoft.AspNetCore.Mvc": "1.1.0-*", |
There was a problem hiding this comment.
I'm guessing this doesn't depend on the metapackage. It would be nice to be more specific.
There was a problem hiding this comment.
Yup, working on removing some of these dependencies.
|
⌚ |
| @@ -41,6 +51,25 @@ public AssemblyPart(Assembly assembly) | |||
| /// <inheritdoc /> | |||
| public IEnumerable<TypeInfo> Types => Assembly.DefinedTypes; | |||
|
|
|||
| public PrecompiledViews PrecompiledViews | |||
There was a problem hiding this comment.
I have some ideas about how to improve the factoring of this in the future, but let's leave that for another PR.
More changes per PR comments
pranavkm
changed the title
|
🆙 📅 Added support for strong name signing + addressed PR comments. Moving this out of design. I'll work on cleaning up the test that was commented out. Tests for this would have to go to a separate repo. I'll work with @Eilon on this. |
| { | ||
| public static readonly string PrecompiledViewsAssemblySuffix = ".PrecompiledViews"; | ||
| public static readonly string ViewCollectionNamespace = "AspNetCore"; | ||
| public static readonly string ViewCollectionTypeName = "__PrecompiledViewCollection"; |
There was a problem hiding this comment.
Is there a reason not to just make these two properties this a single string?
There was a problem hiding this comment.
I use these in codegen, so they have to separated.
|
|
- Let's get this in and address issues in follow ups
|
Moving the Mvc specific changes to a separate commit: #5160. I'll close this once I've addressed PR comments for the tool specific changes. |
cc @rynowak \ @NTaylorMullen \ @davidfowl
No strong naming as yet.