Skip to content
This repository was archived by the owner on Dec 14, 2018. It is now read-only.

Use custom stream writer for Xml output formatters #2541

Closed
kichalla opened this issue May 11, 2015 · 1 comment
Closed

Use custom stream writer for Xml output formatters #2541

kichalla opened this issue May 11, 2015 · 1 comment
Assignees
Milestone

Comments

@kichalla
Copy link
Member

Follow up to #2496

Currently Xml output formatters (DCS and XmlSerializer) do not use the custom stream writer.

XmlWriter however provides an overload which takes in a text writer. We should be able to provide the custom stream writer that we built as part of #2496

@rynowak
Copy link
Member

rynowak commented May 11, 2015

This should probably be generalized to 'do a find and replace for non-disposable stream'. There's a bunch of functional tests where the old pattern was used, and we want as much as is feasible our tests to reflect our recommendation for a user writing the code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants