This repository was archived by the owner on Nov 21, 2018. It is now read-only.
Add kestrel config to CreateDefaultBuilder #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamianEdwards
suggested changes
Dec 21, 2017
| @@ -148,7 +148,10 @@ private static IWebHost StartWith(string url, Action<IServiceCollection> configu | |||
| public static IWebHostBuilder CreateDefaultBuilder(string[] args) | |||
| { | |||
| var builder = new WebHostBuilder() | |||
| .UseKestrel() | |||
| .UseKestrel((builderContext, options) => | |||
There was a problem hiding this comment.
Update the remarks above (and related ones on other overloads) to mention that Kestrel will be configured, e.g.:
/// use Kestrel as the web server and configure it using the application's configuration providers,
Tratcher
force-pushed
the
tratcher/kestrelconfig
branch
from
70d2a8c to
7511a4d
Compare
pakrym
approved these changes
Dec 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kestrel now supports config, but it doesn't read any by default. CreateDefaultBuilder will specify the default location of the Kestrel config section. @DamianEdwards, @danroth27 asked if this config section should be namespaced as "Microsoft:Kestrel" or if a top level "Kestrel" section was ok?
I've also updated an old appsettings.json sample with the new config schema.
See aspnet/KestrelHttpServer#2186