This repository was archived by the owner on Dec 18, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 522
[Testing] Combined Alloc PRs for testing #425
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid allocating the CancellationTokenSource unless it's actually requested. This makes it pay-for-play with regards to code that actually asks for the RequestAborted token and requests that are aborted.
Lazily allocate the RequestAborted CTS
With precomputed tasks Hopefully aspnet#391, the good bits...
… into pr-combined Conflicts: src/Microsoft.AspNet.Server.Kestrel/Http/Frame.cs
…urce' into pr-combined
Remaining big spenders (4k requests):
|
Very nice gain of ~9%:
|
Put [Proposal] back on #411 "Request header Stringpool" needs to looked at in isolation since there wasn't a giant leap. |
A 50% reduction in memory, the GC will like that 👍 |
@halter73 need to do some updates to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs
#424 Improved RequestProcessingAsync legibility
#411 [Proposal] Request header Stringpool
#408 Remove CreateLinkedTokenSource
#363 Resuse writes, initalize queues
Before 7,625,384 bytes used for 4k requests
After 3,817,438 bytes used for 4k requests
Down 3,807,946 bytes (~50% reduction)