This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Unescape string in memory entirely. #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| namespace Microsoft.AspNet.Server.Kestrel.Http | ||
| { | ||
| public class Decoder |
troydai
force-pushed
the
trdai/kestrel124.2
branch
2 times, most recently
from
2d061a0 to
c25f886
Compare
| if (byteCount > 3) | ||
| { | ||
| writer.Put((byte)byte4); | ||
| } |
There was a problem hiding this comment.
Using these if-else structure to avoid allocate a byte array.
troydai
changed the title
troydai
changed the title
troydai
force-pushed
the
trdai/kestrel124.2
branch
from
c25f886 to
b0a85a9
Compare
4 tasks
|
Ping |
| { | ||
| var decodeReader = reader; | ||
|
|
||
| // If decoding process successes, the writer iterator will be moved |
There was a problem hiding this comment.
Thanks. Will update.
|
Ping, updated. |
| [InlineData("%20"," ")] | ||
| [InlineData("%%32", "%2")] | ||
| [InlineData("%%20", "% ")] | ||
| [InlineData("%C0%A4%32", "%C0%A42")] |
There was a problem hiding this comment.
These mixed invalid&valid should be a separate test case.
|
Added iteration to fix a few bugs found in review. I'm adding test cases to cover them. |
troydai
force-pushed
the
trdai/kestrel124.2
branch
4 times, most recently
from
9e1c054 to
33aa245
Compare
|
Ping |
| var chFound = scan.Seek(' ', '?'); | ||
| if (chFound == -1) | ||
|
|
||
| int chFound = -1; |
1. In place unescape; 1. UTF-8 verification; 2. MemoryPoolIterator2.Put 3. Tests
troydai
force-pushed
the
trdai/kestrel124.2
branch
from
94d0898 to
52f4fa9
Compare
|
|
|
all right. I'll wait a bit for Travis. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escape the path url.
Feature:
/cc @lodejard @Tratcher @halter73 @muratg
putfunction toMemoryPoolIterator2for saving byte correctly