-
Notifications
You must be signed in to change notification settings - Fork 523
Conversation
|
||
namespace Microsoft.AspNet.Server.Kestrel.Http | ||
{ | ||
public class Decoder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UrlPathDecoder
2d061a0
to
c25f886
Compare
if (byteCount > 3) | ||
{ | ||
writer.Put((byte)byte4); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using these if-else structure to avoid allocate a byte array.
c25f886
to
b0a85a9
Compare
Ping |
{ | ||
var decodeReader = reader; | ||
|
||
// If decoding process successes, the writer iterator will be moved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nit: succeeds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Will update.
Ping, updated. |
[InlineData("%20"," ")] | ||
[InlineData("%%32", "%2")] | ||
[InlineData("%%20", "% ")] | ||
[InlineData("%C0%A4%32", "%C0%A42")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These mixed invalid&valid should be a separate test case.
Added iteration to fix a few bugs found in review. I'm adding test cases to cover them. |
9e1c054
to
33aa245
Compare
Ping |
var chFound = scan.Seek(' ', '?'); | ||
if (chFound == -1) | ||
|
||
int chFound = -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ch? Character? Separator?
1. In place unescape; 1. UTF-8 verification; 2. MemoryPoolIterator2.Put 3. Tests
94d0898
to
52f4fa9
Compare
|
all right. I'll wait a bit for Travis. |
Escape the path url.
Feature:
/cc @lodejard @Tratcher @halter73 @muratg
put
function toMemoryPoolIterator2
for saving byte correctly