This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Add ListenLocalhost and ListenAnyIP #2159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Nov 15, 2017
| @@ -9,6 +9,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Abstractions.Internal | |||
| public enum ListenType | |||
| { | |||
| IPEndPoint, | |||
| Localhost, | |||
There was a problem hiding this comment.
I understand the feeling. Still better than "Prefix" though.
There was a problem hiding this comment.
I thought about it, I think this is too big of a hack to exist. It doesn't fit the current model. This enum needs to be something else and not part of ListenType.
There was a problem hiding this comment.
Such as? I could drive from Listen options and type check. Or add a second enum IPMode with values LocalhostSplit, AnyIPFallback, and Single. Or derive from ListenOptions and put the bind method on that type. Hmm, that might work...
Tratcher
force-pushed
the
tratcher/localhost3
branch
2 times, most recently
from
19a56db to
fdf9229
Compare
Tratcher
changed the title
|
Rebased and updated with tests, ready for review. |
halter73
reviewed
Nov 16, 2017
src/Kestrel.Core/ListenOptions.cs
Outdated
| @@ -182,5 +183,11 @@ public ConnectionDelegate Build() | |||
|
|
|||
| return app; | |||
| } | |||
|
|
|||
| internal virtual async Task BindAsync(AddressBinder.AddressBindContext context) | |||
There was a problem hiding this comment.
Nit: unnest AddressBindContext
halter73
reviewed
Nov 16, 2017
| } | ||
|
|
||
| private static async Task BindAddressAsync(string address, AddressBindContext context) | ||
| internal static ListenOptions ParseAddress(string address, KestrelServerOptions serverOptions, IDefaultHttpsProvider defaultHttpsProvider) |
Tratcher
force-pushed
the
tratcher/localhost3
branch
from
709c1a2 to
89d1862
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2139 Still needs tests
This abstracts the address parser to work independently of the binder so it can be used for future config code. It also adds first class support for two scenarios formerly only available via UseUrls, ListenLocalhost and ListenAnyIP. Both of these provide dynamic fallback behavior that's not was not possible with a single ListenOptions before.